Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Mar 2020 03:03:02 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r359006 - head/sys/dev/usb/net
Message-ID:  <202003150303.02F3326Z061386@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Sun Mar 15 03:03:01 2020
New Revision: 359006
URL: https://svnweb.freebsd.org/changeset/base/359006

Log:
  muge: enable RXCSUM as it now works
  
  MFC after:	2 weeks
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/sys/dev/usb/net/if_muge.c

Modified: head/sys/dev/usb/net/if_muge.c
==============================================================================
--- head/sys/dev/usb/net/if_muge.c	Sun Mar 15 00:49:06 2020	(r359005)
+++ head/sys/dev/usb/net/if_muge.c	Sun Mar 15 03:03:01 2020	(r359006)
@@ -54,9 +54,7 @@ __FBSDID("$FreeBSD$");
  * A number of features supported by the lan78xx are not yet implemented in
  * this driver:
  *
- * - RX/TX checksum offloading: Nothing has been implemented yet for
- *   TX checksumming. RX checksumming works with ICMP messages, but is broken
- *   for TCP/UDP packets.
+ * - TX checksum offloading: Nothing has been implemented yet.
  * - Direct address translation filtering: Implemented but untested.
  * - VLAN tag removal.
  * - Support for USB interrupt endpoints.
@@ -128,7 +126,6 @@ SYSCTL_INT(_hw_usb_muge, OID_AUTO, debug, CTLFLAG_RWTU
     "Debug level");
 #endif
 
-#define MUGE_DEFAULT_RX_CSUM_ENABLE (false)
 #define MUGE_DEFAULT_TX_CSUM_ENABLE (false)
 #define MUGE_DEFAULT_TSO_CSUM_ENABLE (false)
 
@@ -1616,8 +1613,7 @@ muge_attach_post_sub(struct usb_ether *ue)
 	 */
 	ifp->if_capabilities |= IFCAP_VLAN_MTU;
 	ifp->if_hwassist = 0;
-	if (MUGE_DEFAULT_RX_CSUM_ENABLE)
-		ifp->if_capabilities |= IFCAP_RXCSUM;
+	ifp->if_capabilities |= IFCAP_RXCSUM;
 
 	if (MUGE_DEFAULT_TX_CSUM_ENABLE)
 		ifp->if_capabilities |= IFCAP_TXCSUM;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202003150303.02F3326Z061386>