From owner-freebsd-ports@FreeBSD.ORG Sun Jan 23 17:14:07 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A162106564A for ; Sun, 23 Jan 2011 17:14:07 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id B33C28FC12 for ; Sun, 23 Jan 2011 17:14:06 +0000 (UTC) Received: by bwz12 with SMTP id 12so3069016bwz.13 for ; Sun, 23 Jan 2011 09:14:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=dzmaRJEBzs0H7q40EHfyfsu1UciFmd0623AdU7EO5Cg=; b=WWNEK7SJD3jGPqtDcpFJDO90cXjAWkfFr8rnejX0IgdSs2Yd4vRviEubSn4d8SgOI+ 4fj06Ar46FmYqc0tWE3MFyh6tHA2OX50sie9+nILFgSxkBJEdtrKy/ZsoCadRAL6XMqV NmUEdfwrR92JIqgpXdhjKz/vE+Kcwnw7DfsnA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; b=d1GqdNWoYIeSYIxiMbu+tLqPQ/Byxx0f4rC+cpEjEOAzZrhPc9gbAg15PRI+tvoWw/ UlOPRliP9x+qXVENTtD+Ep3+VcXcYMVVSoJyHTJKISoChtO7LY0ihKmyRGd7V6duyalX kD2Hlf144misxW8Exa1ZRpovrWj1S2HmSEYNI= MIME-Version: 1.0 Received: by 10.204.65.135 with SMTP id j7mr2726326bki.85.1295802844907; Sun, 23 Jan 2011 09:14:04 -0800 (PST) Received: by 10.204.52.19 with HTTP; Sun, 23 Jan 2011 09:14:04 -0800 (PST) Received: by 10.204.52.19 with HTTP; Sun, 23 Jan 2011 09:14:04 -0800 (PST) In-Reply-To: <4D3C5E77.3000702@janh.de> References: <4D39FEBA.3000806@janh.de> <4D3AF40E.7090301@janh.de> <4D3C565A.7060009@janh.de> <4D3C5E77.3000702@janh.de> Date: Sun, 23 Jan 2011 17:14:04 +0000 Message-ID: From: Chris Rees To: Jan Henrik Sylvester Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: ports-list freebsd Subject: Re: Xournal: Please, help me with my first port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: utisoft@gmail.com List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jan 2011 17:14:07 -0000 If prefix works without the CONFIGURE_ARGS then take it out. I put that line in when experimenting with making it datadir safe. The capitalization is my one-person campaign, so I fully expected it to be ignored! Chris -------- Sorry for top-posting, Android won't let me quote, but K-9 can't yet do threading. On 23 Jan 2011 16:59, "Jan Henrik Sylvester" wrote: > On 01/23/2011 17:35, Chris Rees wrote: >> On 23 January 2011 16:24, Jan Henrik Sylvester wrote: >>> On 01/23/2011 11:42, Chris Rees wrote: >>>> >>>> Take a look at the new patch so far; I'm still working on Busybox at >>>> the moment, so I'm afraid I can't step too much more through it, but >>> >>> Just a question about what you did so far: Why the >>> "CONFIGURE_ARGS+=--prefix=${PREFIX}"? I have tested with a different PREFIX >>> before and it was successful -- that is what the second part of the >>> REINPLACE accomplished. What does your line improve? >>> >>> Or is it a first step, if I wanted to make the port DATADIR-safe? > > Should I include that line? > > (I have just retested: The port installs to the correct PREFIX without > that line and seems to be working fine.) > >>> I believe that it is correct what portlint says: "If and only if your port >>> is DATADIR-safe (that is, a user can override DATADIR when building this >>> port and the port will still work correctly) consider using DATADIR macro; >>> if you are unsure if this port is DATADIR-safe, then ignore this warning". >>> Thus, there should not be DATADIR in my pkg-plist as long as the port is not >>> DATADIR-safe. >>> >> >> Perhaps you should ignore the portlint warnings and leave it as >> share/xournal then. > > Thanks. > > BTW: I am going to ignore your capitalization of "makefile" in the first > line, too, since it is non-capitalized in the porters handbook and 20210 > over 240 ports go for the non-capitalized variant. > > Cheers, > Jan Henrik