From nobody Sun Oct 5 13:13:32 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cfjWx12kXz69s61; Sun, 05 Oct 2025 13:13:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cfjWw50BJz3pn7; Sun, 05 Oct 2025 13:13:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759670012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=od5aZZbf1uGQTScPLlUASRuc2Ag1Z0V834hfLmimubc=; b=ANbeLijgFufwMeRXU79xesifvLrs8NZcqB4s5PAcaO9OKDRL3Ziz8FDPq4NsruUu/Zt81B U1qTVVtieWhyKO5OqVKv5clbfIAg5+s+XeNbDWttYEnagjzWCHL5KZRq+E80sqbtdx55kL 4e0SefX2raQlXYWiprTlKUEPxnimL8mbDLJHF1AzWQ6FTmNj1jBm+iGm/LJ2fBqePV5v2I GFAg0dxsGEw/IQ2QyvAsN3ZPjtevuCpwNhzkh94mKdUMq4i5XgEqWUeCA3GoyS+D4c3ZUw +N9hkbHLdxs0B3153vdCakn/7mvwm1MhtciR3cNjV71XeR+JXkNje8ogRe8/bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759670012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=od5aZZbf1uGQTScPLlUASRuc2Ag1Z0V834hfLmimubc=; b=BkpPgyURgM0/Dnari2JbhW8pS4hnQprFqIucaU6Cp6p4TX/L2XvPohDUbvbManfi9ZywKp pnx2COsMqNOWy5nNen9xV8Xl5yCnjX8N1Mf/47Lxu7hnCk4qYB5LXVO+SompxbeeAKoRIq ZUAdwEIVeh5adVzgFXxMVIxGIsXi2EGs/LoaQVA9wQPJqM7RNRG9KYQqg9e2jRxQdxVLno CiJ0JVt2zrBx+NUbZH3TIWWu7Xs257h79DlFMjg5JH5BZS/UPz6N/m7LmbCIb22CVBu3Yf 93UldweHpEt1pA6gxFTFo2txPJsrrkFFxPWgE8mrhJ0kWssEFT7+/CJSDdcsPA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759670012; a=rsa-sha256; cv=none; b=vL3+CjQrRF1uuU0p99i4nmoPzArMzGhyAQKBQ20dQACMEBKzzP/W5TaNtoynNSjFxaCuqu Db1DD9PTaAu+pStwkMa82K6fE79pikkfwulGDSXQSYhFNV6PngDiwCMA3yDmipKFnKuM4W B6FYMP0FTO2R6fU/fB4iNH6FuDJaKaMrrNVhwJTQjFxbB9FBlBTemektrXbYya0OAqggMa Sh19fYVzYl4A4eC3ilK632dE2i5xpBuTSjdG0utxYqQ0JzPQ0FPJaoc6on95hxKs9kSPSG q5wG/2txVX3ps/Epac8GJkJ4WdYK8nREuSaiCgsMTqS8S740KQNcDrX1XasqzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cfjWw4WpQz3m; Sun, 05 Oct 2025 13:13:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 595DDWBx075238; Sun, 5 Oct 2025 13:13:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 595DDWDC075235; Sun, 5 Oct 2025 13:13:32 GMT (envelope-from git) Date: Sun, 5 Oct 2025 13:13:32 GMT Message-Id: <202510051313.595DDWDC075235@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 53b6ea81fa20 - stable/14 - pw: Add a missing chown() when creating dirs in mkdir_home_parents() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 53b6ea81fa201a5699cf00e82a994becd858be2d Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=53b6ea81fa201a5699cf00e82a994becd858be2d commit 53b6ea81fa201a5699cf00e82a994becd858be2d Author: Mark Johnston AuthorDate: 2025-09-18 22:39:11 +0000 Commit: Mark Johnston CommitDate: 2025-10-05 13:13:00 +0000 pw: Add a missing chown() when creating dirs in mkdir_home_parents() mkdir_home_parents() effectively performs a mkdir -p of the root home directory. It chowns the home directory to 0, 0, but doesn't do so for the intermediate directories. Add an explicit chown() call for those too. Fix a long line while here. Reviewed by: bapt MFC after: 1 week Sponsored by: The FreeBSD Foundation Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D52587 (cherry picked from commit 41b2a80353e0dd04939cc260d5763854a264c158) --- usr.sbin/pw/pw_user.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/usr.sbin/pw/pw_user.c b/usr.sbin/pw/pw_user.c index 9f5cfb0f4473..007f750c7d1a 100644 --- a/usr.sbin/pw/pw_user.c +++ b/usr.sbin/pw/pw_user.c @@ -115,7 +115,11 @@ mkdir_home_parents(int dfd, const char *dir) *tmp = '\0'; if (fstatat(dfd, dirs, &st, 0) == -1) { if (mkdirat(dfd, dirs, _DEF_DIRMODE) == -1) - err(EX_OSFILE, "'%s' (home parent) is not a directory", dirs); + err(EX_OSFILE, + "'%s' (home parent) is not a directory", + dirs); + if (fchownat(dfd, dirs, 0, 0, 0) != 0) + warn("chown(%s)", dirs); } *tmp = '/'; }