From nobody Mon Aug 25 08:31:02 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c9PCB39n4z65Q2Q; Mon, 25 Aug 2025 08:31:18 +0000 (UTC) (envelope-from wschnr@googlemail.com) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c9PC85qP4z3hHs; Mon, 25 Aug 2025 08:31:16 +0000 (UTC) (envelope-from wschnr@googlemail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of wschnr@googlemail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=wschnr@googlemail.com Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-45b5c12dd87so10873095e9.2; Mon, 25 Aug 2025 01:31:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756110675; x=1756715475; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=flQ7nszB0D2jKGcie8tKtIpM0Tdv0aM9O7S7y1KuvoQ=; b=INMbHBv03iHsTmiFh0er2d01rhG05FBt5HuvoMHyYtdoasvZ1vuNZv2O37g8SuC0fp 7dsyafnQzJxPBUcaDPDZjQsZsM5lZ7q2uJ8m13/jf8zc9PpIWmTA+UBn0fdB7Oql00zb eheOsvOnFo6vtKUNvcpLgaj7md+tvzx5gcGgemQvRdVWezW7Agci5pLKZXtDoECmtwDN qe6INmwjI0MZ/pQtpn2GKlDcgIBxCdSs+6XD2xmf3S/b8yuXl0PZ7y3q2zqgKcR4EEk9 5ysczgcAbWvwhUvCweZvEqilUu8DsIazpghyh2Ams/cC6KNbAk8UXdFAoq61Av20ettZ xL/g== X-Forwarded-Encrypted: i=1; AJvYcCVj/bJlf1upYO+NdAi3LzhHa0v0tYm7UQWkCYecwTVKAAYq6J+t+FtMvOdvcq4hiwRqAdRmlckiI/+4cy8trvq9JwQX@freebsd.org, AJvYcCVrjBAqAWjaLH91BuQQ7uydXbT9VbHwV1w12WLBOoWYxaHRqJNK8KTxsnQAun+vTkeXAi+6s7/Ed7KQfVPz30siyfmKJxw=@freebsd.org, AJvYcCXLUWhZnHn0FHymJtZu1y5N4etJw+9cNMDWuMpPnjApnuK5wjOUJ3gOrsg6KZel/H1BSbrGFee5R0ZVt/hUOkA=@freebsd.org, AJvYcCXeqYOtwrOCRlGuOxuDmjdSjAPxXXEbgQbdwDfOGoBEuq97cAQ7VFKvEWvdSNmPwLamWQ4v2g==@freebsd.org X-Gm-Message-State: AOJu0YwPvbWLfm0pBOVhv//8ADzcDEz1hYZgWFiLfJeIzr0R8srurkta k+faHMu2Iau2HNQfnX4hJG1iHcCFPOtkRaBRrgdVQWObYIQ/Zbobf0SRYDxnVkNCX6esqBgcnah gQuskSrGL4qyz1Wjjk5j3Ytam7nxAb/FQte8m X-Gm-Gg: ASbGncuPybKxe2d8RKU9t5iipHZRkY6GRKn1OUuquaeBOKhJKbadJ95pllrH8we1KyK 4Gjbu1NmLIHQRngsxs03mLyr1+0kwcIULYScfJOKsBljhKmgttOVrTqKtNRttbbe5ZeZXz5StOc sI4H197H7v1tsFjHGvVHS5vEMPxJWJWnJd2K+miDfEnfsdcVyedh/3HcR3dB0m87if1UCQE6nRP kT6FD51vEyPuzql5m9msVfuxgYQSlT2ypxpxzpBgwn8hpDEjQ/hpl9w61cgw/X27qk79Q== X-Google-Smtp-Source: AGHT+IGGBfRgpeVUeQFsrj1BemXkkE7n/Wz20KcIK0lNJMnHHbALo4BPnIy9mVnB9GjK1tQHNxHCYep4myVrBOlWYTE= X-Received: by 2002:a05:6000:4021:b0:3c8:225d:9e56 with SMTP id ffacd0b85a97d-3c8226ce526mr3433427f8f.50.1756110674387; Mon, 25 Aug 2025 01:31:14 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202508211705.57LH50gR095150@gitrepo.freebsd.org> <39A8B2D8-49D9-4303-A74A-23FB38B867CC@freebsd.org> In-Reply-To: From: Wolfram Schneider Date: Mon, 25 Aug 2025 10:31:02 +0200 X-Gm-Features: Ac12FXyt0rgCBiQiAsXvw4JdAZ9-OfS72N7ZEoQSoMKkGNZGAel4ZxeOTui7Jjo Message-ID: Subject: Re: git: 267f8c1f4b09 - main - crypto/openssl: make vendor imports easier/less error prone To: "Enji Cooper (yaneurabeya)" Cc: Jessica Clarke , Enji Cooper , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-0.93)[-0.930]; NEURAL_HAM_SHORT(-0.67)[-0.671]; FORGED_SENDER(0.30)[wosch@freebsd.org,wschnr@googlemail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FREEMAIL_ENVFROM(0.00)[googlemail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.50:from]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; FREEMAIL_TO(0.00)[gmail.com]; R_DKIM_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.50:from]; FROM_NEQ_ENVFROM(0.00)[wosch@freebsd.org,wschnr@googlemail.com]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCPT_COUNT_FIVE(0.00)[6] X-Rspamd-Queue-Id: 4c9PC85qP4z3hHs On Fri, 22 Aug 2025 at 02:34, Enji Cooper (yaneurabeya) wrote: > > > > On Aug 21, 2025, at 2:07=E2=80=AFPM, Jessica Clarke wrote: > > > > On 21 Aug 2025, at 18:05, Enji Cooper wrote: > >> > >> The branch main has been updated by ngie: > >> > >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D267f8c1f4b09431b335d5f4= 8d84586047471f978 > >> > >> commit 267f8c1f4b09431b335d5f48d84586047471f978 > >> Author: Enji Cooper > >> AuthorDate: 2025-08-01 04:03:33 +0000 > >> Commit: Enji Cooper > >> CommitDate: 2025-08-21 17:02:46 +0000 > >> > >> crypto/openssl: make vendor imports easier/less error prone > >> > >> This change adds a custom BSD makefile containing multiple high-leve= l PHONY > >> targets, similar to targets provided by the ports framework. > >> > >> The Makefile does the following: > >> - Reruns Configure with a deterministic set of arguments to ensure t= hat > >> all appropriate features have been enabled/disabled in OpenSSL. > >> - Preens the pkgconfig files to remove duplicate paths in their > >> `CFLAGS` and `includedir` variables. > >> - Rebuilds all ASM files to ensure that the content contained is fre= sh. > >> - Rebuilds all manpages to ensure that the content contained in the > >> manpages is fresh. > >> > >> Some additional work needs to be done to make the manpage regenerati= on > >> "operation" reproducible (the date the manpages were generated is > >> embedded in the files). > >> > >> All dynamic configuration previously captured in > >> `include/openssl/configuration.h` and `include/crypto/bn_conf.h` has= been > >> moved to `freebsd/include/dynamic_freebsd_configuration.h` and > >> `freebsd/include/crypto/bn_conf.h`, respectively. This helps > >> ensure that future updates don't wipe out FreeBSD customizations to > >> these files, which tune behavior on a per-target architecture basis,= e.g., > >> ARM vs x86, 32-bit vs 64-bit, etc. > >> > >> MFC after: 1 month > >> Differential Revision: https://reviews.freebsd.org/D51663 > > > > Something in this breaks building on macOS (where, as of recently, we > > build libcrypto as a bootstrap library for use by the certctl bootstrap > > tool): > > > > /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bi= o_sock2.c:64:9: error: call to undeclared function 'ktls_enable'; ISO C99 a= nd later do not support implicit function declarations [-Wimplicit-function= -declaration] > > ktls_enable(sock); > > ^ > > /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bi= o_sock2.c:202:5: error: call to undeclared function 'ktls_enable'; ISO C99 = and later do not support implicit function declarations [-Wimplicit-functio= n-declaration] > > ktls_enable(sock); > > ^ > > 2 errors generated. > > --- bio_sock2.o --- > > *** [bio_sock2.o] Error code 1 > > > > Presumably you need a BOOTSTRAPPING check somewhere. > > It looks like the problem is MacOS doesn=E2=80=99t support KTLS and now K= TLS has been fixed on FreeBSD. > > MK_OPENSSL_KTLS needs to be disabled when doing =E2=80=9Cmake bootstrappi= ng=E2=80=9D on MacOS. setting MK_OPENSSL_KTLS=3Dno does not unbreak building on macOS. You have to disable the ssl build at all with MK_OPENSSL=3Dno to get it running again. -Wolfram --=20 Wolfram Schneider https://wolfram.schneider.org