From owner-freebsd-numerics@FreeBSD.ORG Sun Aug 12 22:57:51 2012 Return-Path: Delivered-To: freebsd-numerics@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3780D1065675 for ; Sun, 12 Aug 2012 22:57:51 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vps.rulingia.com (host-122-100-2-194.octopus.com.au [122.100.2.194]) by mx1.freebsd.org (Postfix) with ESMTP id 978E98FC25 for ; Sun, 12 Aug 2012 22:57:50 +0000 (UTC) Received: from server.rulingia.com (c220-239-249-137.belrs5.nsw.optusnet.com.au [220.239.249.137]) by vps.rulingia.com (8.14.5/8.14.5) with ESMTP id q7CMvobC075506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 08:57:50 +1000 (EST) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.14.5/8.14.5) with ESMTP id q7CMvij0020892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 13 Aug 2012 08:57:44 +1000 (EST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.14.5/8.14.5/Submit) id q7CMviJ0020891 for freebsd-numerics@freebsd.org; Mon, 13 Aug 2012 08:57:44 +1000 (EST) (envelope-from peter) Resent-From: Peter Jeremy Resent-Date: Mon, 13 Aug 2012 08:57:44 +1000 Resent-Message-ID: <20120812225744.GI20453@server.rulingia.com> Resent-To: freebsd-numerics@freebsd.org From: Peter Jeremy Mail-Followup-To: freebsd-numerics@freebsd.org To: Steve Kargl Message-ID: <20120718001337.GA87817@server.rulingia.com> References: <20120713155805.GC81965@zim.MIT.EDU> <20120714120432.GA70706@server.rulingia.com> <20120717084457.U3890@besplex.bde.org> <5004A5C7.1040405@missouri.edu> <5004DEA9.1050001@missouri.edu> <20120717040118.GA86840@troutmask.apl.washington.edu> <20120717042125.GF66913@server.rulingia.com> <20120717043848.GB87001@troutmask.apl.washington.edu> <20120717225328.GA86902@server.rulingia.com> <20120717232740.GA95026@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oC1+HKm2/end4ao3" Content-Disposition: inline In-Reply-To: <20120717232740.GA95026@troutmask.apl.washington.edu> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Diane Bruce , John Baldwin , David Chisnall , Stephen Montgomery-Smith , Bruce Evans , Bruce Evans , David Schultz , Warner Losh Subject: Re: Use of C99 extra long double math functions after r236148 X-BeenThere: freebsd-numerics@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of high quality implementation of libm functions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 12 Aug 2012 22:57:51 -0000 X-Original-Date: Wed, 18 Jul 2012 10:13:37 +1000 X-List-Received-Date: Sun, 12 Aug 2012 22:57:51 -0000 --oC1+HKm2/end4ao3 Content-Type: multipart/mixed; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Jul-17 16:27:40 -0700, Steve Kargl wrote: >I won't have time to go over the code in detail until >this weekend, but a quick peek showed some issues. The >first is style. Although fdlibm has a rather interest >coding style, new code should use KNF. I hope that was only the function declaration lines. I think the rest is KNF. >I think you're missing a sign. Let z =3D x + i*y. >Then, i*z =3D i*x+i*i*y =3D -y + i*x, yielding Yes, I think you're right in both cases. I wasn't thinking clearly. (Something to automatically generate this sort of code would mean you only need to write it once). Try the attached (also at http://www.rulingia.com/~peter/catan.c ). And I'm aware it has UTF-8 in the comments. I can't quickly find anything on character sets in style(9) and would apppreciate a ruling on it. --=20 Peter Jeremy --TB36FDmn/VVEgNH/-- --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlAF/7EACgkQ/opHv/APuIdEVACfdN6+ABauEDyKCXwxmnVKy0IK SN8An0vC0SpUmF59NCBlUlInGFLEPzB4 =pTWJ -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3--