Date: Sun, 12 Aug 2012 22:57:51 -0000 From: Peter Jeremy <peter@rulingia.com> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: Diane Bruce <db@db.net>, John Baldwin <jhb@freebsd.org>, David Chisnall <theraven@freebsd.org>, Stephen Montgomery-Smith <stephen@missouri.edu>, Bruce Evans <bde@freebsd.org>, Bruce Evans <brde@optusnet.com.au>, David Schultz <das@freebsd.org>, Warner Losh <imp@bsdimp.com> Subject: Re: Use of C99 extra long double math functions after r236148 Message-ID: <20120718001337.GA87817@server.rulingia.com> Resent-Message-ID: <20120812225744.GI20453@server.rulingia.com> In-Reply-To: <20120717232740.GA95026@troutmask.apl.washington.edu> References: <20120713155805.GC81965@zim.MIT.EDU> <20120714120432.GA70706@server.rulingia.com> <20120717084457.U3890@besplex.bde.org> <5004A5C7.1040405@missouri.edu> <5004DEA9.1050001@missouri.edu> <20120717040118.GA86840@troutmask.apl.washington.edu> <20120717042125.GF66913@server.rulingia.com> <20120717043848.GB87001@troutmask.apl.washington.edu> <20120717225328.GA86902@server.rulingia.com> <20120717232740.GA95026@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--oC1+HKm2/end4ao3 Content-Type: multipart/mixed; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Jul-17 16:27:40 -0700, Steve Kargl <sgk@troutmask.apl.washington.ed= u> wrote: >I won't have time to go over the code in detail until >this weekend, but a quick peek showed some issues. The >first is style. Although fdlibm has a rather interest >coding style, new code should use KNF. I hope that was only the function declaration lines. I think the rest is KNF. >I think you're missing a sign. Let z =3D x + i*y. >Then, i*z =3D i*x+i*i*y =3D -y + i*x, yielding Yes, I think you're right in both cases. I wasn't thinking clearly. (Something to automatically generate this sort of code would mean you only need to write it once). Try the attached (also at http://www.rulingia.com/~peter/catan.c ). And I'm aware it has UTF-8 in the comments. I can't quickly find anything on character sets in style(9) and would apppreciate a ruling on it. --=20 Peter Jeremy --TB36FDmn/VVEgNH/-- --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlAF/7EACgkQ/opHv/APuIdEVACfdN6+ABauEDyKCXwxmnVKy0IK SN8An0vC0SpUmF59NCBlUlInGFLEPzB4 =pTWJ -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120718001337.GA87817>