From owner-freebsd-current@FreeBSD.ORG Thu Oct 18 00:12:33 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ABF414F1 for ; Thu, 18 Oct 2012 00:12:33 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2A29C8FC0C for ; Thu, 18 Oct 2012 00:12:32 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so3719542bkc.13 for ; Wed, 17 Oct 2012 17:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=s/3FKKm13d6k24jSpKqes5LhP5WiRyOGocSf/nzbgWE=; b=WzK24JKROLcENbWc7SoihczepeQEJlKw9B56+RMqEKtL8QPLfwolMPaLoXG6FnkEes OBywQ22kDSvTr4SvA3AtsG3FT/9mqdhwPLolftLW7J5mPlzdX8sBf2dRDB37P8G81rhT g3h1lgsIdfIRWwUnuW3/3CiyVUHTZJfDbwxfp9r6GLwyfg2z+tsL1OKiW09u+uQ/Afou 1YPwtxcD9XkeIMJVo5Z7Fowe0pUo9KwswP+wM357+Fu3lGKQfaHsShgVwWXp3H5dzVE+ qOVEGUD8ChJ+YT6vAsiBvnIG0g+fR1drupgZlxPul1pPwmbR3E9AElZG92ck4ERJ3QL6 ieSA== MIME-Version: 1.0 Received: by 10.204.128.201 with SMTP id l9mr5612203bks.66.1350519151496; Wed, 17 Oct 2012 17:12:31 -0700 (PDT) Received: by 10.205.36.136 with HTTP; Wed, 17 Oct 2012 17:12:31 -0700 (PDT) In-Reply-To: References: <1349390777.5234.9.camel@powernoodle.corp.yahoo.com> Date: Wed, 17 Oct 2012 17:12:31 -0700 Message-ID: Subject: Re: [CFT]hwpmc update for sandybridge-e From: hiren panchasara To: Jim Harris Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Davide Italiano , freebsd-current , Fabien Thomas X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2012 00:12:33 -0000 On Wed, Oct 17, 2012 at 5:00 PM, Jim Harris wrote: > On Wed, Oct 17, 2012 at 3:57 PM, hiren panchasara > wrote: > > > > > > > > > Thanks for the pointers Jim! > > > > It seems that everything works now with: > > > > http://www.strugglingcoder.info/patches/hwpmc_sbx_3.txt > > http://www.strugglingcoder.info/patches/pmccontrol_3.txt > > http://www.strugglingcoder.info/patches/pmctestpy_3.txt > > > > As it can be seen, I do not see any errors with the test script. > > I've also tried to take care of the sorting issues Fabien mentioned. > > > > Can you please give this a whirl? > > Looks good! Version 3 passes pmctest.py on my system. > Great! Thanks a lot for testing. > > > > > > > > > I have a few questions regarding this. For my testing I am using hwpmc > as a > > module. > > Problem is that any change to pmc_events.h is not reflected when I do: > > 1) rebuild /sys/modules/hwpmc - unload/load new module > > 2) rebuild /lib/libpmc/ > > 3) rebuild /usr.sbin/pmccontrol and pmcstat > > > > I have to do buildworld for changes in pmc_events.h to take effect. > (which > > kind of explains my delayed responses :D ) > > I know I am missing something here and there should be a better way to do > > this. Any other changes (other than pmc_events.h) > > can be tested with above 3 steps. > > You forgot to mention sys/pmc.h, but that was a simple change so you > probably haven't had to touch it since your initial patch. > > The quick and dirty way is to just copy sys/dev/hwpmc/pmc_events.h to > /usr/include/dev/hwpmc. Also sys/sys/pmc.h to /usr/include/sys. > Nice...! Appreciate your help, Hiren > > Thanks, > > -Jim > > >> > >> Thanks for working on this! > > > > Entirely my pleasure :-) > > > > Thanks, > > Hiren > > >