From owner-cvs-src@FreeBSD.ORG Fri Jan 21 01:23:25 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA86416A4CE; Fri, 21 Jan 2005 01:23:25 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C984643D2D; Fri, 21 Jan 2005 01:23:25 +0000 (GMT) (envelope-from peter@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j0L1NPHg009493; Fri, 21 Jan 2005 01:23:25 GMT (envelope-from peter@repoman.freebsd.org) Received: (from peter@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j0L1NP1u009492; Fri, 21 Jan 2005 01:23:25 GMT (envelope-from peter) Message-Id: <200501210123.j0L1NP1u009492@repoman.freebsd.org> From: Peter Wemm Date: Fri, 21 Jan 2005 01:23:25 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4 Subject: cvs commit: src/sys/nfs nfs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jan 2005 01:23:26 -0000 peter 2005-01-21 01:23:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) sys/nfs nfs_vfsops.c Log: Yet another pass on trying to fix the nfs statfs large-fs blocksize scaler. Casting the result of the 64 bit division to 32 bits (thus discarding the upper 32 bits) and then looking at the truncated result to try and figure out if the untruncated result would fit in 32 bits was utterly useless. I am still not sure that it is right, but it has a chance of working now. I'm not at all sure about the sign handling. NFSv3 only reports positive values here, but correctness of handling the 63/64 bit signs on nfs volumes is not a problem we'll likely have to deal with for some time. I think the "most correct" test is for an unsigned division testing for exceeding LONG_MAX, since we should never end up with a negative number to compare against LONG_MIN. Revision Changes Path 1.91.2.9 +6 -6 src/sys/nfs/nfs_vfsops.c