From owner-cvs-all Tue Sep 11 5:11:31 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 93CC637B40C; Tue, 11 Sep 2001 05:11:04 -0700 (PDT) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f8BCARm48984; Tue, 11 Sep 2001 15:10:27 +0300 (EEST) (envelope-from ru) Date: Tue, 11 Sep 2001 15:10:27 +0300 From: Ruslan Ermilov To: =?koi8-r?Q?S=F8ren_Schmidt?= Cc: =?koi8-r?Q?S=F8ren_Schmidt?= , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/burncd burncd.8 burncd.c Message-ID: <20010911151027.B47073@sunbay.com> References: <20010911150539.A47073@sunbay.com> <200109111208.f8BC8Si07878@freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: <200109111208.f8BC8Si07878@freebsd.dk>; from sos@freebsd.dk on Tue, Sep 11, 2001 at 02:08:28PM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Sep 11, 2001 at 02:08:28PM +0200, Søren Schmidt wrote: > It seems Ruslan Ermilov wrote: > [ Charset KOI8-R unsupported, converting... ] > > On Tue, Sep 11, 2001 at 04:52:50AM -0700, S?ren Schmidt wrote: > > > sos 2001/09/11 04:52:50 PDT > > > > > > Modified files: > > > usr.sbin/burncd burncd.8 burncd.c > > > Log: > > > Fixes from Ruslan Ermilov: > > > > > [...] > > > 4. Nuke the prog_name variable burncd.c, use getprogname(3). ^^^^^^^^^^^^^^^^^^ Here's what I've complained to. The code just nukes the variable. > > > > > Uhh, here's what I actually said: > > > > : The patch for burncd.c also nukes the prog_name variable. > > : If it's at all needed (and this contradicts what style(9) > > : says), please use getprogname(3) instead. > > > > What I meant was is that if you need that prog_name variable, > > you should initialize it from getprogname(3), not from argv[0]. > > Yep, but I dont need it for anything but the usage() stuff... -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message