From owner-cvs-src@FreeBSD.ORG  Sat Apr  8 05:08:18 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8EA6016A406;
	Sat,  8 Apr 2006 05:08:18 +0000 (UTC)
	(envelope-from scottl@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4ADE243D46;
	Sat,  8 Apr 2006 05:08:18 +0000 (GMT)
	(envelope-from scottl@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k3858IiY074611;
	Sat, 8 Apr 2006 05:08:18 GMT
	(envelope-from scottl@repoman.freebsd.org)
Received: (from scottl@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k3858ImJ074610;
	Sat, 8 Apr 2006 05:08:18 GMT (envelope-from scottl)
Message-Id: <200604080508.k3858ImJ074610@repoman.freebsd.org>
From: Scott Long <scottl@FreeBSD.org>
Date: Sat, 8 Apr 2006 05:08:17 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/dev/amr amr.c amr_pci.c amrvar.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Apr 2006 05:08:18 -0000

scottl      2006-04-08 05:08:17 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/amr          amr.c amr_pci.c amrvar.h 
  Log:
  After further review and discussion, partially revert the previous commit.
  The real problem was that ioctl handlers needed to call amr_wait_command()
  with the list lock held.  This not only solves the completion race, it also
  prevents bounce buffer corruption that could arise from amr_start() being
  called without the proper locks held.
  
  Discussed with: ps
  MFC After: 3 days
  
  Revision  Changes    Path
  1.77      +13 -18    src/sys/dev/amr/amr.c
  1.36      +0 -1      src/sys/dev/amr/amr_pci.c
  1.32      +0 -1      src/sys/dev/amr/amrvar.h