From owner-freebsd-arm@FreeBSD.ORG Fri Apr 4 16:42:57 2008 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71B971065672; Fri, 4 Apr 2008 16:42:57 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 4EF518FC1F; Fri, 4 Apr 2008 16:42:57 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m34GguwP037603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Apr 2008 09:42:57 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <47F65A90.6030803@freebsd.org> Date: Fri, 04 Apr 2008 09:42:56 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: John Baldwin References: <200804031514.33243.jhb@FreeBSD.org> <47F5A87C.1000804@freebsd.org> <47F5A8E0.7010803@freebsd.org> In-Reply-To: <47F5A8E0.7010803@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-Rhyolite-Metrics: ebb.errno.com; whitelist Cc: arm@freebsd.org Subject: Re: A patch to simplify the MD interrupt code a bit.. X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Apr 2008 16:42:57 -0000 Sam Leffler wrote: > Sam Leffler wrote: >> John Baldwin wrote: >>> This patch adds an MI intr_event_handle() routine for the non-FILTER >>> case so that the MD code becomes identical in both cases and all the >>> INTR_FILTER #ifdef's end up in kern_intr.c. It's been tested on >>> amd64, i386, and sparc64 and cross-compiled on ppc, arm, and ia64. >>> I'd like to get it tested on arm as I slightly adjusted the MD code >>> to just not bother masking the interrupt unless we are going to run >>> an ithread which is mostly what the existing FILTER code did except >>> that it unmasked the interrupt when it wasn't masked in the first >>> place if a filter handled the interrupt. Patch is at >>> http://www.freebsd.org/~jhb/patches/intr_filter.patch >>> >>> >> Seems to be ok on an AVILA board w/ latest HEAD. > > Ooops, hold that. Your patch doesn't apply cleanly and I missed > that. Will try again tomorrow. > Works fine on my Avila 2348 board. Sam