From owner-svn-ports-head@FreeBSD.ORG  Mon Oct  8 07:16:45 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 60CD6106564A;
	Mon,  8 Oct 2012 07:16:45 +0000 (UTC)
	(envelope-from bapt@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4266F8FC16;
	Mon,  8 Oct 2012 07:16:45 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q987GjRq090284;
	Mon, 8 Oct 2012 07:16:45 GMT (envelope-from bapt@FreeBSD.org)
Received: (from bapt@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q987GjiW090283;
	Mon, 8 Oct 2012 07:16:45 GMT (envelope-from bapt@FreeBSD.org)
X-Authentication-Warning: freefall.freebsd.org: bapt set sender to
	bapt@FreeBSD.org using -f
Date: Mon, 8 Oct 2012 09:16:42 +0200
From: Baptiste Daroussin <bapt@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Message-ID: <20121008071642.GA91360@ithaqua.etoilebsd.net>
References: <201210061123.q96BNHVx053948@svn.freebsd.org>
	<20121008040154.GB91369@FreeBSD.org>
	<20121008045905.GD91369@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/"
Content-Disposition: inline
In-Reply-To: <20121008045905.GD91369@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: svn commit: r305357 - head/net/ssvnc
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree for head
	<svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>, 
	<mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
	<mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Oct 2012 07:16:45 -0000


--TB36FDmn/VVEgNH/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 08, 2012 at 04:59:06AM +0000, Alexey Dokuchaev wrote:
> On Mon, Oct 08, 2012 at 04:01:54AM +0000, Alexey Dokuchaev wrote:
> > On Sat, Oct 06, 2012 at 11:23:17AM +0000, Baptiste Daroussin wrote:
> > > New Revision: 305357
> > > URL: http://svn.freebsd.org/changeset/ports/305357
> > >=20
> > > Log:
> > >   fix sense of a test
> > >  =20
> > > -.if ${PORT_OPTIONS:MULTRAFTP}
> > > +.if empty(PORT_OPTIONS:MULTRAFTP)
> >=20
> > That looks weird, and commit message is pretty cryptic as well.  Could =
you
> > explain what went wrong here so others would not fall in the same pitfa=
ll?
>=20
> Err, I read is as ! vs. empty() test.  Still, I've noticved some arguments
> on the syntax, would be nice to know if ! ${PORT_OPTIONS:M...} has issues
> other than purely stylish.
>=20

No it hasn't (as far as I know)

Bapt

--TB36FDmn/VVEgNH/
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlByfdoACgkQ8kTtMUmk6ExlTQCdHHEfLgnyFE1Vax5xlqTYuDtJ
w+gAoKN2jVhTeXWiChZPhhYEEBs9C9j/
=qP1w
-----END PGP SIGNATURE-----

--TB36FDmn/VVEgNH/--