Date: Sun, 11 Apr 2021 01:10:17 +0200 From: Adriaan de Groot <adridg@freebsd.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, ale@freebsd.org Subject: Re: git: c6093a753e76 - main - databases/mysql55-server: fix check-plist Message-ID: <2226559.mfXeX5GmMH@beastie.bionicmutton.org> In-Reply-To: <34dabf10-5e9b-37da-2d74-b4f38a357b2e@pfeifer.com> References: <202104090946.1399kTCb092931@gitrepo.freebsd.org> <34dabf10-5e9b-37da-2d74-b4f38a357b2e@pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2814748.slGk94SIus
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"; protected-headers="v1"
From: Adriaan de Groot <adridg@freebsd.org>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, ale@freebsd.org
Subject: Re: git: c6093a753e76 - main - databases/mysql55-server: fix check-plist
Date: Sun, 11 Apr 2021 01:10:17 +0200
Message-ID: <2226559.mfXeX5GmMH@beastie.bionicmutton.org>
Organization: FreeBSD
In-Reply-To: <34dabf10-5e9b-37da-2d74-b4f38a357b2e@pfeifer.com>
References: <202104090946.1399kTCb092931@gitrepo.freebsd.org> <34dabf10-5e9b-37da-2d74-b4f38a357b2e@pfeifer.com>
On Friday, 9 April 2021 23:50:07 CEST Gerald Pfeifer wrote:
> On Fri, 9 Apr 2021, Adriaan de Groot wrote:
> > databases/mysql55-server: fix check-plist
> >
> > An empty directory `info` is created during install; it's
> > not listed in the plist. Get rid of it.
>
> Is it possible this ...
>
> > +post-install:
> > + # Empty directory, but check-plist complains
> > + @${RMDIR} ${STAGEDIR}${PREFIX}/info || ${TRUE}
>
> ... is papering over the real issue?
It is definitely paper-thin.
> Then, looking a bit more: Is this port even dealing with .info files
> at all?
No. Omitting the CMake argument changes the problem to "now there is an
orphaned directory docs/". I suppose I *could* make it point somewhere that
already exists, and then drop the post-install papering -- I'd prefer it if
ale@ (maintainer, CC'ed) made that call, though: my primary concern is to deal
simple with all the package-build failures that occur *before* upgrading
CMake.
> What happens if you simply omit -DINSTALL_INFODIR="info" ?
>
> Or make it point to another, existing directory (such as "share")?
--nextPart2814748.slGk94SIus
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit
-----BEGIN PGP SIGNATURE-----
iQGzBAABCAAdFiEEhrjttu2OP5apuuy1z93JbxKxkVwFAmByMFkACgkQz93JbxKx
kVyvVgv/TB5nEILkVP3qFfVsn9HMhtIycFt74IkbMcm/mcN1NqZsf4FPFnEEnU6l
rgTk2bgBNbVZ3xr67MmkynNQi4KuaPoZAgSqOQLxxh/XBbt19hvDsyIIRdu0eTXa
Uih9doU/aWkkwq6meqFSvyjUJpBRpwF6UIJ+zY9svvxgu3K6jjt8cJU1VonmCoGN
M3TgCtJCJDVKbb8U60QWCwL9HGdnLXDCozyq93VXoFBg4MixKBz2BWAMHFq+o6jy
OAHYPzxoh5qASLa3/omDPJBE5QxHedN8JCzCjWhiztrBFk8qnUozIMK9zIme1LZS
6mOH/4jLxNj8dw04WPiEklaynxHPsiUDtOmfVqbO8q6wz44X7vjmS2bE7evyLrJe
/n+FW3IHX5/ilX493yCq/QPcuLSjqQ79llBr5Q/PHwn7wWJ/a93bncuTK9JJGSbw
hCbU/Bw1/s6qwveKhlQ0fPAvl3LgCeo91zVPHDrKqEJ0ADVGJFG6sf+T9QJR5+CQ
K5/owlTl
=4YDG
-----END PGP SIGNATURE-----
--nextPart2814748.slGk94SIus--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2226559.mfXeX5GmMH>