From owner-freebsd-ports@FreeBSD.ORG Fri Dec 23 02:05:14 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07F73106568E; Fri, 23 Dec 2011 02:05:14 +0000 (UTC) (envelope-from glarkin@FreeBSD.org) Received: from mail1.sourcehosting.net (mail1.sourcehosting.net [74.205.51.45]) by mx1.freebsd.org (Postfix) with ESMTP id 21EE18FC17; Fri, 23 Dec 2011 02:05:09 +0000 (UTC) Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235] helo=imac.entropy.prv) by mail1.sourcehosting.net with esmtp (Exim 4.73 (FreeBSD)) (envelope-from ) id 1RduVJ-000MmO-LN; Thu, 22 Dec 2011 21:05:04 -0500 Received: from imac.entropy.prv (localhost [127.0.0.1]) by imac.entropy.prv (Postfix) with ESMTP id 22109D01410; Thu, 22 Dec 2011 21:05:06 -0500 (EST) Message-ID: <4EF3E1D1.1020901@FreeBSD.org> Date: Thu, 22 Dec 2011 21:05:05 -0500 From: Greg Larkin Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.25) Gecko/20111213 Lightning/1.0b2 Thunderbird/3.1.17 MIME-Version: 1.0 References: <4EEC6D9D.1020102@yandex.ru> <4EEEAE03.1080908@yandex.ru> <4EF2FBAE.8050406@yandex.ru> <4EF393BC.2020003@yandex.ru> <4EF3CF11.6070104@FreeBSD.org> <4EF3E0EF.8040405@FreeBSD.org> In-Reply-To: <4EF3E0EF.8040405@FreeBSD.org> X-Enigmail-Version: 1.1.1 OpenPGP: id=1C940290 X-SA-Exim-Connect-IP: 68.189.245.235 X-SA-Exim-Mail-From: glarkin@FreeBSD.org X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail1.sourcehosting.net X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=AWL, BAYES_00, MISSING_HEADERS, RCVD_IN_RP_RNBL, RCVD_IN_SORBS_DUL, RDNS_DYNAMIC, TVD_RCVD_IP autolearn=no version=3.3.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Version: 4.2 X-SA-Exim-Scanned: Yes (on mail1.sourcehosting.net) Cc: Doug Barton , Christer Edwards , "freebsd-ports@FreeBSD.org" Subject: Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: glarkin@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 02:05:14 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/22/11 9:01 PM, Greg Larkin wrote: > On 12/22/11 8:34 PM, Christer Edwards wrote: >> On Thu, Dec 22, 2011 at 5:45 PM, Doug Barton wrote: >>> There are some style problems and one real bug that are repeated for all >>> 3 scripts. I attached a fixed version of one of them, hopefully that >>> will help you see what's needed to fix the other 2. Also, please review >>> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html, >>> especially the pre-commit checklist. > >> I made the changes you suggested and tried a fresh build of the port >> inside of a jail. Below is a pastebin of trying to start the >> service(s) just after installation. > >> http://pastebin.com/raw.php?i=2wGBk0PY > >> thanks > > Hi Christer, > > The salt-master script is interpreted by Python, so I believe you'll > need the following in your rc.d script: > > command_interpreter="%%PYTHON_CMD%%" > > and the proper SUB_LIST setting in the Makefile. Check the py-fail2ban > port for some pointers on that. > > Hope that helps, > Greg Also, I forgot to mention that when I'm faced with similar rc.d problems, I invoke the script with "sh -x" like so: sh -x /usr/local/etc/rc.d/viewvc start That prints all of the shell variable debug information, echoes commands, etc. I would be interested in seeing that output if you can post it to pastebin. I'm not sure my previous suggestion will help anyway, and it looks like your $command variable is trashed somewhere while the script executes. Regards, Greg -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7z4dEACgkQ0sRouByUApDzfgCgkoTH5sNuPr+jEdbp9rplFD2b BoAAoJbTTQBZi0oL8URD7C71/7hsKVgU =Uu2Z -----END PGP SIGNATURE-----