From owner-freebsd-current@FreeBSD.ORG  Fri Sep 10 12:27:48 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id 62C551065674; Fri, 10 Sep 2010 12:27:48 +0000 (UTC)
Date: Fri, 10 Sep 2010 12:27:48 +0000
From: Alexander Best <arundel@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20100910122748.GA1834@freebsd.org>
References: <20100909191750.GA58228@freebsd.org>
	<20100909194109.GA64914@freebsd.org>
	<20100909195045.GA68352@freebsd.org>
	<201009100747.39964.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201009100747.39964.jhb@freebsd.org>
Cc: freebsd-current@freebsd.org
Subject: Re: {arch}/conf/DEFAULTS and uart
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Sep 2010 12:27:48 -0000

On Fri Sep 10 10, John Baldwin wrote:
> On Thursday, September 09, 2010 3:50:45 pm Alexander Best wrote:
> > On Thu Sep  9 10, Alexander Best wrote:
> > > On Thu Sep  9 10, Alexander Best wrote:
> > > > hi there,
> > > > 
> > > > except for arm most archs seem to enforce uart support in conf/DEFAULTS. is
> > > > this really necessary? shouldn't DEFAULTS only contain vital devices/options
> > > > without a kernel on a specific arch won't function at all?
> > > 
> > > jhb just explained to me, that the uart entry in DEFAULTS is not a controller
> > > or something like that, but the uart backend to use *if* uart gets defined in
> > > the kernel config.
> > > 
> > > sorry for the noise folks.
> > 
> > however i found some missing comments and incorrect syntax which i fixed.
> > 
> > see the attached patch.
> 
> I think the ia64 ordering for 'io and mem' is probably more correct
> (alphabetically sorted), so I would fix i386 and amd64 and leave ia64 alone.
> 
> The powerpc 'machine' changes are wrong I think as it would break GENERIC64
> and powerpc64 kernel configs in general.  Nathan purposefully removed
> 'machine' from the powerpc DEFAULTS.

thanks for the feedback. i'll hack in the changes and will send out a new patch
on monday or so. :)

cheers.
alex

>  
> -- 
> John Baldwin

-- 
a13x