From owner-freebsd-bugs@FreeBSD.ORG  Fri Apr 15 08:30:33 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4D98316A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 15 Apr 2005 08:30:33 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2E4F843D1F
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 15 Apr 2005 08:30:33 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3F8UXHB050414
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 15 Apr 2005 08:30:33 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3F8UWwJ050412;
	Fri, 15 Apr 2005 08:30:32 GMT
	(envelope-from gnats)
Date: Fri, 15 Apr 2005 08:30:32 GMT
Message-Id: <200504150830.j3F8UWwJ050412@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Julian Elischer <julian@elischer.org>
Subject: Re: kern/79884: [PATCH] ng_echo(4) should use "error" from
	NG_FWD_ITEM_HOOK
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Julian Elischer <julian@elischer.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Apr 2005 08:30:33 -0000

The following reply was made to PR kern/79884; it has been noted by GNATS.

From: Julian Elischer <julian@elischer.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Cc: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>,
	Julian Elischer <julian@FreeBSD.org>, bug-followup@FreeBSD.org
Subject: Re: kern/79884: [PATCH] ng_echo(4) should use "error" from NG_FWD_ITEM_HOOK
Date: Fri, 15 Apr 2005 01:27:07 -0700

 Ruslan Ermilov wrote:
 > On Wed, Apr 13, 2005 at 10:12:29PM +0000, Wojciech A. Koszek wrote:
 > [...]
 > 
 >>NG_FWD_ITEM_HOOK prepends to "error" appropriate value if needed. Currently,
 >>"error" is not used after NG_FWD_ITEM_HOOK. ng_echo(4) should make use of
 >>it.
 >>
 > 
 > Julian changed the semantics in rev. 1.9 of ng_echo.c, without an obvious
 > reason.  Let's hear what was the reason, if there were any.  Julian?
 
 probably just a "braino" during editing, though I think there is a large
 possibility that it is not possible to get an error.
 certainly it should be ok to use the error value,
 
 > 
 > 
 > Cheers,