From owner-cvs-all Tue Mar 27 23:35: 2 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 3EB5337B719; Tue, 27 Mar 2001 23:34:56 -0800 (PST) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.1/8.11.1) with SMTP id f2S7Yoh04006; Wed, 28 Mar 2001 02:34:50 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Wed, 28 Mar 2001 02:34:50 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Warner Losh Cc: Jeroen Ruigrok/Asmodai , "Andrey A. Chernov" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/tail forward.c In-Reply-To: <200103280732.f2S7We952543@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 28 Mar 2001, Warner Losh wrote: > In message <20010328064206.A90260@daemon.ninth-circle.org> Jeroen Ruigrok/Asmodai writes: > : -On [20010328 01:30], Andrey A. Chernov (ache@FreeBSD.org) wrote: > : > fseeko(file_size, SEEK_SET) -> fseek(0L, SEEK_END) > : > : Shouldn't 0L actually be NULL? > > No. fseek takes a long offset. fseek(fp, 0L, SEEK_END) is correct. So clearly the reality of the patch differed from the comment, because your code snippet != comment code snippet. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message