From owner-svn-src-head@freebsd.org Wed Sep 13 06:14:44 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C8D32E0ECD7; Wed, 13 Sep 2017 06:14:44 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x241.google.com (mail-pg0-x241.google.com [IPv6:2607:f8b0:400e:c05::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 96F4174E1B; Wed, 13 Sep 2017 06:14:44 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x241.google.com with SMTP id v5so7216531pgn.4; Tue, 12 Sep 2017 23:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hO1Dgci4GKz2QHN9AtOEkdwPdNqcbeskPocf7YmL3Lg=; b=DTagQTtKztTj0/cq0WFQ2aksT6ZTFbIvCDAivPC9znZhaSQ7q0fPkt7+id3NIB3M2T XF3ZdYzkc5jF5X9pmzRg/B4SxbtlCGN3ZqDXSqRJs4erXr0tn0qm0rByg66x9sXwnS7G xCSlMyzZYma85m44dvKANV/YfHjegjpRT+Yu4ew9PzvjcRfie6jwFAmnCQEnIlSqRAvb Qlf4y2OYVO0WRJGErAU96+o2DOGQR8CihpT7cv+9aTXzNBNzDjveLPPbyaPkRdpmuf1z W0jCs5qnlbuEjR5cyH7oUMQUJtQGmM4CIYYUeJhPOC7NSnuTLYyf8VpmkrHGUJxotr8x reUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=hO1Dgci4GKz2QHN9AtOEkdwPdNqcbeskPocf7YmL3Lg=; b=nCnVm2+InRQlIwaR9h9jS65To1Jz6GTH8MYncn3E4m65r4iYrzT+Kwh6qJAY+/4a+Y bICIdMpMvaBKq6NDNeA+Kz7kZt8KzdMavyjXMYdgHeYoAcbn04HTKfz+8hoiwNkSZx33 +ynJUq5riyQ2MOWm8pOtFtPItUAv/oIqjxyDFkSibXASD9bj733X56uybWaUBIC8/ga3 0OLl+VCn1/lNxfoXjVS7DjhyTNWrJ4DU2chOYB6rYj0K61XJgwIH94WigUJGhDommKtG KEU/GjNEAz5cm/8N8iR3XZRzwFe8Ciq7ly7dl7uer+Mpr1lpuNQSkeGmGVNAMAiXp3AB fofA== X-Gm-Message-State: AHPjjUjClpPkyaVyFPdK/g9ltHkMhh4L38T2WN3uDIkl8rGmrC7oP04e WqNXGx05/z0fhlQ37NBqlQ== X-Google-Smtp-Source: ADKCNb6S/gDpa+qzu1Ap+CSZJyFJi9u3K1lQ1gWAP/8XWT9pQIASxmKw3ZTTg7Ks+EF1avfx/YHpow== X-Received: by 10.99.126.84 with SMTP id o20mr16410090pgn.273.1505283283734; Tue, 12 Sep 2017 23:14:43 -0700 (PDT) Received: from ?IPv6:2607:fb90:9dce:72a3:4135:819b:49e7:7507? ([2607:fb90:9dce:72a3:4135:819b:49e7:7507]) by smtp.gmail.com with ESMTPSA id v25sm22486209pfg.52.2017.09.12.23.14.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Sep 2017 23:14:43 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys From: Ngie Cooper X-Mailer: iPhone Mail (14G60) In-Reply-To: <201709130118.v8D1IgvB029215@repo.freebsd.org> Date: Tue, 12 Sep 2017 23:14:35 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <4D5AE475-5A38-4429-8B71-DBECDFB0A1FF@gmail.com> References: <201709130118.v8D1IgvB029215@repo.freebsd.org> To: Stephen Hurd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 06:14:44 -0000 > On Sep 12, 2017, at 18:18, Stephen Hurd wrote: > > Author: shurd > Date: Wed Sep 13 01:18:42 2017 > New Revision: 323516 > URL: https://svnweb.freebsd.org/changeset/base/323516 > > Log: > Roll up iflib commits from github. This pulls in most of the work done > by Matt Macy as well as other changes which he has accepted via pull > request to his github repo at https://github.com/mattmacy/networking/ > > This should bring -CURRENT and the github repo into close enough sync to > allow small feature branches rather than a large chain of interdependant > patches being developed out of tree. The reset of the synchronization > should be able to be completed on github by splitting the remaining > changes that are not yet ready into short feature branches for later > review as smaller commits. > > Here is a summary of changes included in this patch: > > 1) More checks when INVARIANTS are enabled for eariler problem > detection > 2) Group Task Queue cleanups > - Fix use of duplicate shortdesc for gtaskqueue malloc type. > Some interfaces such as memguard(9) use the short description to > identify malloc types, so duplicates should be avoided. > 3) Allow gtaskqueues to use ithreads in addition to taskqueues > - In some cases, this can improve performance > 4) Better logging when taskqgroup_attach*() fails to set interrupt > affinity. > 5) Do not start gtaskqueues until they're needed > 6) Have mp_ring enqueue function enter the ABDICATED rather than BUSY > state. This moves the TX to the gtaskq and allows processing to > continue faster as well as make TX batching more likely. > 7) Add an ift_txd_errata function to struct if_txrx. This allows > drivers to inspect/modify mbufs before transmission. > 8) Add a new IFLIB_NEED_ZERO_CSUM for drivers to indicate they need > checksums zeroed for checksum offload to work. This avoids modifying > packet data in the TX path when possible. > 9) Use ithreads for iflib I/O instead of taskqueues > 10) Clean up ioctl and support async ioctl functions > 11) Prefetch two cachlines from each mbuf instead of one up to 128B. We > often need to parse packet header info beyond 64B. > 12) Fix potential memory corruption due to fence post error in > bit_nclear() usage. > 13) Improved hang detection and handling > 14) If the packet is smaller than MTU, disable the TSO flags. > This avoids extra packet parsing when not needed. > 15) Move TCP header parsing inside the IS_TSO?() test. > This avoids extra packet parsing when not needed. > 16) Pass chains of mbufs that are not consumed by lro to if_input() > rather call if_input() for each mbuf. > 17) Re-arrange packet header loads to get as much work as possible done > before a cache stall. > 18) Lock the context when calling IFDI_ATTACH_PRE()/IFDI_ATTACH_POST()/ > IFDI_DETACH(); > 19) Attempt to distribute RX/TX tasks across cores more sensibly, > especially when RX and TX share an interrupt. RX will attempt to > take the first threads on a core, and TX will attempt to take > successive threads. > 20) Allow iflib_softirq_alloc_generic() to request affinity to the same > cpus an interrupt has affinity with. This allows TX queues to > ensure they are serviced by the socket the device is on. > 21) Add new iflib sysctls to net.iflib: > - timer_int - interval at which to run per-queue timers in ticks > - force_busdma > 22) Add new per-device iflib sysctls to dev.X.Y.iflib > - rx_budget allows tuning the batch size on the RX path > - watchdog_events Count of watchdog events seen since load > 23) Fix error where netmap_rxq_init() could get called before > IFDI_INIT() > 24) e1000: Fixed version of r323008: post-cold sleep instead of DELAY > when waiting for firmware > - After interrupts are enabled, convert all waits to sleeps > - Eliminates e1000 software/firmware synchronization busy waits after > startup > 25) e1000: Remove special case for budget=1 in em_txrx.c > - Premature optimization which may actually be incorrect with > multi-segment packets > 26) e1000: Split out TX interrupt rather than share an interrupt for > RX and TX. > - Allows better performance by keeping RX and TX paths separate > 27) e1000: Separate igb from em code where suitable > Much easier to understand separate functions and "if (is_igb)" than > previous tests like "if (reg_icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC))" > > #blamebruno > > Reviewed by: sbruno > Approved by: sbruno (mentor) > Sponsored by: Limelight Networks > Differential Revision: https://reviews.freebsd.org/D12235 *gasps at the LoC count and number of changed drivers* Could someone please better break this up in the future..? Thank you, -Ngie