From owner-freebsd-ports-bugs@FreeBSD.ORG Tue May 26 07:20:01 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 75CD21065688 for ; Tue, 26 May 2009 07:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4EE1F8FC26 for ; Tue, 26 May 2009 07:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n4Q7K1RA081474 for ; Tue, 26 May 2009 07:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n4Q7K1aa081473; Tue, 26 May 2009 07:20:01 GMT (envelope-from gnats) Resent-Date: Tue, 26 May 2009 07:20:01 GMT Resent-Message-Id: <200905260720.n4Q7K1aa081473@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nathan Whitehorn Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 34ADA106566B for ; Tue, 26 May 2009 07:14:20 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 07AEA8FC13 for ; Tue, 26 May 2009 07:14:20 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n4Q7EJ9t037643 for ; Tue, 26 May 2009 07:14:19 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n4Q7EJoI037642; Tue, 26 May 2009 07:14:19 GMT (envelope-from nobody) Message-Id: <200905260714.n4Q7EJoI037642@www.freebsd.org> Date: Tue, 26 May 2009 07:14:19 GMT From: Nathan Whitehorn To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/134948: [PATCH] math/suitesparse fails to build with METIS enabled and does not install SPQR headers X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2009 07:20:01 -0000 >Number: 134948 >Category: ports >Synopsis: [PATCH] math/suitesparse fails to build with METIS enabled and does not install SPQR headers >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 26 07:20:00 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Nathan Whitehorn >Release: 8.0-CURRENT >Organization: University of Wisconsin >Environment: FreeBSD wanderer.tachypleus.net 8.0-CURRENT FreeBSD 8.0-CURRENT #0 r192697M: Sun May 24 23:51:14 CEST 2009 root@wanderer.tachypleus.net:/usr/obj/usr/src/sys/WANDERER amd64 >Description: SPQR headers are left out of the list of headers to be installed in the main port makefile. The CHOLMOD Makefile also becomes confused about where the METIS headers can be found (appending /Lib to METIS_PATH), so the build fails if you enable METIS. >How-To-Repeat: >Fix: The attached patch fixes both of these, with a few lines of changes. Patch attached with submission follows: diff -urN suitesparse.dist/Makefile suitesparse/Makefile --- suitesparse.dist/Makefile 2009-05-26 08:57:54.000000000 +0200 +++ suitesparse/Makefile 2009-05-26 08:48:52.000000000 +0200 @@ -130,6 +130,7 @@ ${INSTALL_DATA} ${WRKSRC}/CXSparse/Include/*.h ${PREFIX}/include/suitesparse ${INSTALL_DATA} ${WRKSRC}/KLU/Include/*.h ${PREFIX}/include/suitesparse ${INSTALL_DATA} ${WRKSRC}/CAMD/Include/*.h ${PREFIX}/include/suitesparse + ${INSTALL_DATA} ${WRKSRC}/SPQR/Include/*.h ${PREFIX}/include/suitesparse ${INSTALL_DATA} ${WRKDIR}/tmp_static/*.a ${PREFIX}/lib ${INSTALL_DATA} ${WRKDIR}/tmp_shared/*.so.${SVERSION} ${PREFIX}/lib ${INSTALL_DATA} ${WRKDIR}/tmp_shared/*.so ${PREFIX}/lib diff -urN suitesparse.dist/files/patch-CHOLMOD+Lib+Makefile suitesparse/files/patch-CHOLMOD+Lib+Makefile --- suitesparse.dist/files/patch-CHOLMOD+Lib+Makefile 1970-01-01 01:00:00.000000000 +0100 +++ suitesparse/files/patch-CHOLMOD+Lib+Makefile 2009-05-26 08:54:12.000000000 +0200 @@ -0,0 +1,11 @@ +--- CHOLMOD/Lib/Makefile.dist 2009-05-26 08:53:07.000000000 +0200 ++++ CHOLMOD/Lib/Makefile 2009-05-26 08:53:22.000000000 +0200 +@@ -116,7 +116,7 @@ + $(OBJ): $(INC) + + I = -I../../AMD/Include -I../../AMD/Source -I../../COLAMD/Include \ +- -I$(METIS_PATH)/Lib -I../../CCOLAMD/Include -I../../CAMD/Include \ ++ -I$(METIS_PATH) -I../../CCOLAMD/Include -I../../CAMD/Include \ + -I../Include -I../../UFconfig + + #------------------------------------------------------------------------------- >Release-Note: >Audit-Trail: >Unformatted: