From owner-freebsd-bugs@FreeBSD.ORG  Wed Jun 23 21:41:03 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 276FF16A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 23 Jun 2004 21:41:03 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 21E9B43D1D
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 23 Jun 2004 21:41:03 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i5NLeRRv002316
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 23 Jun 2004 21:40:27 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5NLeRUP002315;
	Wed, 23 Jun 2004 21:40:27 GMT
	(envelope-from gnats)
Date: Wed, 23 Jun 2004 21:40:27 GMT
Message-Id: <200406232140.i5NLeRUP002315@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Alex Vasylenko <lxv@omut.org>
Subject: Re: bin/65892: ee(1) endless loop
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Alex Vasylenko <lxv@omut.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jun 2004 21:41:03 -0000

The following reply was made to PR bin/65892; it has been noted by GNATS.

From: Alex Vasylenko <lxv@omut.org>
To: freebsd-gnats-submit@FreeBSD.org, eugen@grosbein.pp.ru
Cc:  
Subject: Re: bin/65892: ee(1) endless loop
Date: Wed, 23 Jun 2004 17:34:36 -0400

 This is a multi-part message in MIME format.
 --------------090303020200050609060303
 Content-Type: text/plain; charset=us-ascii; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Eugene Grosbein wrote:
  > There are situations when ee(1) starts to eat all CPU cycles.
  > ee /tmp/file &
 
 - the code sets to ignore (SIG_IGN) first 23 signals including SIGTTIN, 
 SIGTTOU;
 
  > ee </dev/null
 
 - the code doesn't check STDIN_FILENO, STDOUT_FILENO for isatty;
 
 Please see the patch.
 
 -- 
 Alex.
 
 
 --------------090303020200050609060303
 Content-Type: text/plain;
  name="ee.c.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="ee.c.diff"
 
 --- ee.c.orig	Mon Jun 30 07:51:21 2003
 +++ ee.c	Wed Jun 23 17:02:28 2004
 @@ -544,10 +544,11 @@ main(argc, argv)		/* beginning of main p
  int argc;
  char *argv[];
  {
 -	int counter;
 -
 -	for (counter = 1; counter < 24; counter++)
 -		signal(counter, SIG_IGN);
 +	/* Always read from (and write to) a terminal. */
 +	if (!isatty(STDIN_FILENO) || !isatty(STDOUT_FILENO)) {
 +		fprintf(stderr, "ee's standard input and output must be a terminal\n");
 +		exit(1);
 +	}
  
  	signal(SIGCHLD, SIG_DFL);
  	signal(SIGSEGV, SIG_DFL);
 
 --------------090303020200050609060303--