From owner-freebsd-hackers Wed Mar 6 1:13:54 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 5D29237B400; Wed, 6 Mar 2002 01:13:51 -0800 (PST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.2/8.12.2) with ESMTP id g269DYLv014190; Wed, 6 Mar 2002 10:13:35 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: "Mike Meyer" Cc: "Mike Meyer" , "Mike Meyer" , obrien@FreeBSD.ORG, Giorgos Keramidas , hackers@FreeBSD.ORG Subject: Re: RFC: style(9) isn't explicit about booleans for testing. In-Reply-To: Your message of "Wed, 06 Mar 2002 02:51:06 CST." <15493.55418.457017.332630@guru.mired.org> Date: Wed, 06 Mar 2002 10:13:34 +0100 Message-ID: <14189.1015406014@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <15493.55418.457017.332630@guru.mired.org>, "Mike Meyer" writes: >Poul-Henning Kamp types: >> In message <15493.51038.957711.450030@guru.mired.org>, "Mike Meyer" writes: >> I'm advocating that the rule focus on readability rather than trying >> to enforce a type which doesn't exist. > >Excellent idea. Can you provide verbiage and examples? All you have to do is get rid of the word boolean, ie: change Do not use ! for tests unless it is a boolean, e.g. use to Do not use ! for tests unless it is an integer type, e.g. use And as far as I'm concerned the confusion is gone. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message