From owner-svn-src-all@freebsd.org Tue Apr 24 17:39:01 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA9DDFAD030; Tue, 24 Apr 2018 17:39:01 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 65FD87F310; Tue, 24 Apr 2018 17:39:01 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from [192.168.200.3] (c-73-216-227-39.hsd1.va.comcast.net [73.216.227.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: gallatin) by duke.cs.duke.edu (Postfix) with ESMTPSA id 76EEE2700351; Tue, 24 Apr 2018 13:38:55 -0400 (EDT) DMARC-Filter: OpenDMARC Filter v1.3.1 duke.cs.duke.edu 76EEE2700351 Authentication-Results: duke.cs.duke.edu; dmarc=none header.from=cs.duke.edu DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cs.duke.edu; s=mail0816; t=1524591535; bh=AIigYlzXYmmqwvkspdwHcRTl+o7DiR8sfyXVCqzRnTU=; h=Subject:To:From:Date:From; b=DDC/JuMczayhGDq5EP8EQDTQGZHRVjW2khwE0QOCz79hoL+rd/osJvyAf5kFvLSB5 ZADqTCYz2yiOIjrzuYjkIOsUp13vDDJFjFVZ+TrbyInzsbYeheCq6LrXLrH5xoXb0d TnjQBmViLeDLyfSD5k8T/0GzFYnOXf5vn9hvkQdfc0g2AyhnqvRpbF2hP/8SXsEzfP w4nKfAIWz1VeFCSWEiilj1+bkWg+aNeFBTOuqk/8zFAYAkMcEzZZpEoNuvnfRK3gDw MMk9h4Fz3hMAm21xi635sq5ikupNRqkM2tWtXHsOIeaYd/zXjEonyuB8MCjrpDlVq0 f/tm9shO7Fzsw== Subject: Re: svn commit: r332860 - head/sys/kern To: "Jonathan T. Looney" , John Baldwin Cc: Mark Johnston , cem@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201804211705.w3LH50Dk056339@repo.freebsd.org> <20180423180024.GC84833@raichu> <1739228.8pyHcvzasL@ralph.baldwin.cx> From: Andrew Gallatin Message-ID: <744fa604-c33c-5f58-6443-4c485136b4fb@cs.duke.edu> Date: Tue, 24 Apr 2018 13:38:53 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 17:39:01 -0000 On 04/24/18 13:24, Jonathan T. Looney wrote: > On Mon, Apr 23, 2018 at 6:04 PM, John Baldwin > wrote: > > > > I think this is actually a key question.  In my experience to date I > have not > > encountered a large number of post-panic assertion failures.  Given that > > we already break all locks and disable assertions for locks I'd be > curious > > which assertions are actually failing.  My inclination given my > experiences > > to date would be to explicitly ignore those as we do for locking if it is > > constrained set rather than blacklisting all of them.  However, I > would be > > most interested in seeing some examples of assertions that are failing. > > The latest example (the one that prompted me to finally commit this) is > in lockmgr_sunlock_try(): 'panic: Assertion (*xp & > ~LK_EXCLUSIVE_SPINNERS) == LK_SHARERS_LOCK(1) failed at > /usr/src/sys/kern/kern_lock.c:541' > > I don't see any obvious recent changes that would have caused this, so > this is probably a case where a change to another file suddenly made us > trip over this assert. FWIW, that assertion has prevented me from getting a dump from an INVARIANTS kernel for at least a year. Drew