From owner-cvs-all Mon Sep 23 23:43:38 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 556B037B401; Mon, 23 Sep 2002 23:43:36 -0700 (PDT) Received: from eken2.eken.phys.nagoya-u.ac.jp (eken2.eken.phys.nagoya-u.ac.jp [133.6.121.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id DAE7543E7B; Mon, 23 Sep 2002 23:43:34 -0700 (PDT) (envelope-from yoichi@eken.phys.nagoya-u.ac.jp) Received: from debian.eken.phys.nagoya-u.ac.jp (e-ppp0.eken.phys.nagoya-u.ac.jp [133.6.121.50]) by eken2.eken.phys.nagoya-u.ac.jp (8.11.6+3.4W/3.7W-E) with ESMTP id g8O6hWI08010; Tue, 24 Sep 2002 15:43:32 +0900 (JST) Date: Tue, 24 Sep 2002 15:43:59 +0900 Message-ID: <878z1rsx8w.wl@eken.phys.nagoya-u.ac.jp> From: Yoichi NAKAYAMA To: Ying-Chieh Liao , llwang@infor.org Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, daichi@jp.FreeBSD.org Subject: Re: cvs commit: ports/www/flashplugin-mozilla Makefile In-Reply-To: <200209210054.g8L0sDEW059533@freefall.freebsd.org> <20020924145615.5ca29f1e.daichi@jp.freebsd.org> References: <200209210054.g8L0sDEW059533@freefall.freebsd.org> User-Agent: Wanderlust/2.9.15 (Unchained Melody) SEMI/1.14.4 (Hosorogi) FLIM/1.14.5 (Demachiyanagi) APEL/10.3 Emacs/21.2 (i386-debian-linux-gnu) MULE/5.0 (SAKAKI) Organization: E-ken, Dept. of Physics, Nagoya University, JAPAN X-Face: wLZki+KbGjgKe0,<&3g*rA|R**vj[a8L%[v]ecJh1L(Uqm|LBx;v7Nq7n%?0d.aS]F#[~C\!{m?m,C&#U5}$_pZvBR>5VmX1Ol0`P\M-U8`sUF<5Quj'z&zzW8r|Zl9#W7Wut3duYzpKrP{n+AbarKtJ!i"Al7]P;-?[=iBZa*]r=>C':0~JECx]IH+RXq=/hUX}MB9e]oQKBxsDd/ MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At Fri, 20 Sep 2002 17:54:13 -0700 (PDT),Ying-Chieh Liao wrote: > > ijliao 2002/09/20 17:54:13 PDT > > Modified files: > www/flashplugin-mozilla Makefile > Log: > install properly for mozilla-devel > > PR: 43135 > Submitted by: maintainer > > Revision Changes Path > 1.3 +7 -0 ports/www/flashplugin-mozilla/Makefile It seems not proper. It will register run-dependency to mozilla port even if it installes plugin for mozilla-devel, besidess the PLIST does not follow the change. Apply following patch and create stub port flashplugin-mozilla-devel overriding RUN_DEPENDES and PLUGIN_DIR seems better way. Index: Makefile =================================================================== RCS file: /home/ncvs/ports/www/flashplugin-mozilla/Makefile,v retrieving revision 1.3 diff -u -r1.3 Makefile --- Makefile 21 Sep 2002 00:54:13 -0000 1.3 +++ Makefile 24 Sep 2002 06:40:57 -0000 @@ -16,20 +16,15 @@ MAINTAINER= llwang@infor.org LIB_DEPENDS= flash.0:${PORTSDIR}/graphics/libflash -RUN_DEPENDS= mozilla:${PORTSDIR}/www/mozilla +RUN_DEPENDS?= mozilla:${PORTSDIR}/www/mozilla USE_X_PREFIX= yes WRKSRC= ${WRKDIR}/${DISTNAME}/Plugin +PLUGIN_DIR?= lib/mozilla/plugins +PLIST_SUB+= PLUGIN_DIR=${PLUGIN_DIR} do-install: -.if exists(${X11BASE}/lib/mozilla) - @${ECHO_MSG} "Installing flashplugin for mozilla" - @${INSTALL_PROGRAM} ${WRKSRC}/npflash.so ${X11BASE}/lib/mozilla/plugins -.endif -.if exists(${X11BASE}/lib/mozilla-devel) - @${ECHO_MSG} "Installing flashplugin for mozilla-devel" - @${INSTALL_PROGRAM} ${WRKSRC}/npflash.so ${X11BASE}/lib/mozilla-devel/plugins -.endif + @${INSTALL_PROGRAM} ${WRKSRC}/npflash.so ${X11BASE}/${PLUGIN_DIR} .include Index: pkg-plist =================================================================== RCS file: /home/ncvs/ports/www/flashplugin-mozilla/pkg-plist,v retrieving revision 1.1 diff -u -r1.1 pkg-plist --- pkg-plist 2 Nov 2001 13:58:55 -0000 1.1 +++ pkg-plist 24 Sep 2002 06:35:36 -0000 @@ -1 +1 @@ -lib/mozilla/plugins/npflash.so +%%PLUGIN_DIR%%/npflash.so To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message