From owner-svn-src-head@FreeBSD.ORG Fri Mar 21 19:13:28 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 24FE4EC2; Fri, 21 Mar 2014 19:13:28 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D329E669; Fri, 21 Mar 2014 19:13:27 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s2LJ42UJ084804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Mar 2014 12:04:02 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s2LJ42tN084803; Fri, 21 Mar 2014 12:04:02 -0700 (PDT) (envelope-from jmg) Date: Fri, 21 Mar 2014 12:04:02 -0700 From: John-Mark Gurney To: Ian Lepore Subject: Re: svn commit: r263424 - head/sys/arm/conf Message-ID: <20140321190402.GT32089@funkthat.com> References: <201403201701.s2KH1L84024044@svn.freebsd.org> <20140321094316.76ccf459@bender.Home> <1395412070.81853.8.camel@revolution.hippie.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395412070.81853.8.camel@revolution.hippie.lan> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Fri, 21 Mar 2014 12:04:03 -0700 (PDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Ruslan Bukin , src-committers@freebsd.org, Andrew Turner X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Mar 2014 19:13:28 -0000 Ian Lepore wrote this message on Fri, Mar 21, 2014 at 08:27 -0600: > On Fri, 2014-03-21 at 09:43 +0000, Andrew Turner wrote: > > On Thu, 20 Mar 2014 17:01:21 +0000 (UTC) > > Ruslan Bukin wrote: > > > > > Author: br > > > Date: Thu Mar 20 17:01:21 2014 > > > New Revision: 263424 > > > URL: http://svnweb.freebsd.org/changeset/base/263424 > > > > > > Log: > > > Disable debugging by default. > > > > I don't like this on head. I have found a number of issues that were > > hidden because the kernel config most people were using for development > > had WITNESS, INVARIANTS and DIAGNOSTIC disabled. I agree... HEAD needs these to make sure they are production ready... > I disagree. Witness is essentially useless anymore, because there are > so many known LORs that nobody cares about when you report them that all > it does is spews noise. Maybe it's useful when you're looking for a > particular problem, but leaving it on all the time has just lost its > value. I wouldn't be tracking down an AVILA bug if it wasn't for INVARIANTS.. Also, your complaint is solely about WITNESS not the other ones... Considering how many people are writing new drivers for ARM, and might be introducing locking issues w/ those new drivers, WITNESS should be included, plus, if you disable INVARIANTS, it means that all the lock assert functions will be turned off, and we might miss an odd calling stack which doesn't hold a lock or something... If you're using HEAD for performance, it's easy to turn these off.. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."