Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 20 Sep 2016 11:08:15 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 212849] games/osgg: Unbreak fetch, improve
Message-ID:  <bug-212849-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212849

            Bug ID: 212849
           Summary: games/osgg: Unbreak fetch, improve
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: amdmi3@FreeBSD.org
          Reporter: lightside@gmx.com
                CC: amdmi3@FreeBSD.org
 Attachment #174999 maintainer-approval?(amdmi3@FreeBSD.org)
             Flags:
             Flags: maintainer-feedback?(amdmi3@FreeBSD.org)
          Assignee: amdmi3@FreeBSD.org
                CC: amdmi3@FreeBSD.org

Created attachment 174999
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D174999&action=
=3Dedit
Proposed patch (since 422447 revision)

Patch to unbreak games/osgg and improve port.

- Unbreak fetch with using available distfile
- Adapt WRKSRC value
- Remove -f argument near ${RM} value
- Put cd related commands in parenthesis
- Regenerate distinfo file with using `make makesum` command and correct
TIMESTAMP value

Note about parenthesis for cd related commands:
-8<--
man make | grep "in parenthesis" -h5 | tail -8
     Makefiles should be written so that the mode of make operation does not
     change their behavior.  For example, any command which needs to use "c=
d"
     or "chdir", without side-effect should be put in parenthesis:


           avoid-chdir-side-effects:
                   @echo Building $@ in `pwd`
                   @(cd ${.CURDIR} && ${.MAKE} $@)
-->8-

Note about ${RM} value and -f argument:
-8<--
make -C /usr/ports -V RM
/bin/rm -f
-->8-

How TIMESTAMP value was generated (for this case):
make clean extract && find work/* -type f -print0 | xargs -0 stat -f '%m' |
sort -u | tail -1 && make clean
or
make clean extract && find work/* -type f -exec stat -f '%m' {} + | sort -u=
 |
tail -1 && make clean

--=20
You are receiving this mail because:
You are the assignee for the bug.=

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-212849-13>