From owner-freebsd-current@FreeBSD.ORG Thu Nov 20 22:01:31 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C76441065675 for ; Thu, 20 Nov 2008 22:01:31 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.247]) by mx1.freebsd.org (Postfix) with ESMTP id 7E74B8FC18 for ; Thu, 20 Nov 2008 22:01:31 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by an-out-0708.google.com with SMTP id b6so314836ana.13 for ; Thu, 20 Nov 2008 14:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=OhSLYSR+ubfbyhgVfCH1kqO/f3SlRo7xdSQ+Ji0jmtQ=; b=cVxcq7nD97TAS5ZHx/xKau2CogXAQfx51laNo9pejBm6HXKYN6rJwsQ8osQaczCeEM ZLZ1FPHKkTm/9CMfb2glfPpdFGphFJDDWiWPJrcFPOHNqCiGoQkVkEvEZl7tT70n/bPr P0alPJWzN/a3KwIUBaLrRffnE+bFvSfk2x9xU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=CytpWOvBljirZWhYTWOB5I8iUf7BNds9exoHvyV1lnQhCWTiysW4z6VbXR7gDRqFt1 TCHD+6LQJ7OtUCepfibso49EQM5zcQTcpEPGvXekeHpcVQ8omsAjR7528nOPmWX22LcT HuDKgr6yk7DWgVx0NZwGy1P+IFfJD+N+ty9qk= Received: by 10.231.20.3 with SMTP id d3mr25397ibb.18.1227216657130; Thu, 20 Nov 2008 13:30:57 -0800 (PST) Received: by 10.231.15.70 with HTTP; Thu, 20 Nov 2008 13:30:57 -0800 (PST) Message-ID: <3a142e750811201330p3084255em390d94b352dee532@mail.gmail.com> Date: Thu, 20 Nov 2008 22:30:57 +0100 From: "Paul B. Mahol" To: "John Baldwin" In-Reply-To: <200811191510.53793.jhb@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200811191510.53793.jhb@FreeBSD.org> Cc: current@freebsd.org Subject: Re: [PATCH] MPSAFE/LOOKUP_SHARED cd9660 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Nov 2008 22:01:31 -0000 On 11/19/08, John Baldwin wrote: > This is a relatively simple patch to mark cd9660 MPSAFE and enable shared > lookups. The changes to cd9660_lookup() mirror similar changes to > ufs_lookup() to use static variables for local data rather than abusing > i-node members of the parent directory. I've done some light testing of > this, but not super-strenuous. This patch also includes simple locking for > the iconv support in the kernel. That locking uses an sx lock to serialize > open and close of translator tables and the associated refcount. Actual > conversions do not need any locks, however as the mount holds a reference on > the table. > > http://www.FreeBSD.org/~jhb/patches/cd9660_mpsafe.patch > With this patch I'm unable to kldunload libiconv.ko once it is loaded. And trying to kldunload libiconv.ko will make any next kldload/kldstat/kldunload to fail waiting forever(livelock). Regression were not encountered while only cd9660.ko were kldloaded. BTW: Machine crashed during clean shutdown (with old kernel without this patch) after atapicd where kldloaded and after that used some time and tham kldunloaded.