Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Oct 2014 18:16:45 -0700
From:      Cy Schubert <Cy.Schubert@komquats.com>
To:        Dmitry Sivachenko <demon@FreeBSD.org>
Cc:        Antoine Brodin <antoine@FreeBSD.org>, python@freebsd.org
Subject:   Re: svn commit: r371567 - in head/lang/python34: . files
Message-ID:  <201410290116.s9T1GjV2081414@slippy.cwsent.com>
In-Reply-To: Message from Dmitry Sivachenko <demon@FreeBSD.org> of "Tue, 28 Oct 2014 18:21:15 %2B0300." <805A5998-26F1-4CAB-A565-382C13509F9A@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multipart MIME message.

--==_Exmh_1414545361_49340
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

In message <805A5998-26F1-4CAB-A565-382C13509F9A=40FreeBSD.org>, Dmitry=20
Sivachenk
o writes:
>=20
> > On 28 =D0=BE=D0=BA=D1=82. 2014 =D0=B3., at 12:38, Antoine Brodin <ant=
oine=40FreeBSD.org> wrote:
> >=20
> > On Tue, Oct 28, 2014 at 9:30 AM, Dmitry Sivachenko <demon=40freebsd.o=
rg> wrot
> e:
> >>=20
> >>> On 28 =D0=BE=D0=BA=D1=82. 2014 =D0=B3., at 12:29, Antoine Brodin <a=
ntoine=40FreeBSD.org> wrote:
> >>>=20
> >>> On Mon, Oct 27, 2014 at 12:54 PM, Dmitry Sivachenko <demon=40freebs=
d.org> w
> rote:
> >>>> Author: demon
> >>>> Date: Mon Oct 27 12:54:04 2014
> >>>> New Revision: 371567
> >>>> URL: https://svnweb.freebsd.org/changeset/ports/371567
> >>>> QAT: https://qat.redports.org/buildarchive/r371567/
> >>>>=20
> >>>> Log:
> >>>> Update to version 3.4.2.
> >>>> Two deleted patches were integrated upstream.
> >>>>=20
> >>>> Reviewed by:  koobs in D967
> >>>>=20
> >>>> Deleted:
> >>>> head/lang/python34/files/patch-issue21166
> >>>> head/lang/python34/files/patch-issue21704
> >>>> Modified:
> >>>> head/lang/python34/Makefile
> >>>> head/lang/python34/distinfo
> >>>> head/lang/python34/files/patch-Makefile.pre.in
> >>>> head/lang/python34/files/patch-Modules-_ctypes-libffi-configure
> >>>> head/lang/python34/pkg-plist
> >>>=20
> >>> Hi,
> >>>=20
> >>> This fails to build on i386 (_ctypes/libffi error)
> >>=20
> >>=20
> >> Where can I see build logs?  QAT link leads to empty page.
> >=20
> > I have this log:
> >=20
> > http://gohan1.ysv.freebsd.org/data/101i386-default-baseline/2014-10-2=
7_21h2
> 7m36s/logs/errors/python34-3.4.2.log
> >=20
>=20
>=20
> Well, I can't figure ATM what's wrong with _ctypes and libffi.  But the=
 propo
> sed patch to use libffi from ports should fix that.
> What do you think about this patch (and to force it unconditionally for=
 i386)
> ?
>=20
> BTW, I took a look at NetBSD pkgsrc: they always build python with libf=
fi fro
> m ports (--with-system-libffi).

Would anyone mind if I committed the patch I posted last night (PDT)? Her=
e=20
it is for anyone who's missed it.





--==_Exmh_1414545361_49340
Content-Type: text/plain ; name="pathon-port.diffs"; charset=iso-8859-1
Content-Description: pathon-port.diffs
Content-Disposition: attachment; filename="pathon-port.diffs"
Content-Transfer-Encoding: quoted-printable

Index: python27/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- python27/Makefile	(revision 371620)
+++ python27/Makefile	(working copy)
=40=40 -2,7 +2,7 =40=40
=20
 PORTNAME=3D	python27
 PORTVERSION=3D	2.7.8
-PORTREVISION=3D	5
+PORTREVISION=3D	6
 CATEGORIES=3D	lang python ipv6
 MASTER_SITES=3D	PYTHON
 MASTER_SITE_SUBDIR=3D	ftp/python/=24=7BPORTVERSION=7D
=40=40 -34,8 +34,8 =40=40
 			PORTVERSION=3D=24=7BPORTVERSION=7D =5C
 			OSMAJOR=3D=24=7BOSVERSION:C/(=5B0-9=5D*)=5B0-9=5D=7B5=7D/=5C1/=7D		=
=23 For plat-freebsd* in pkg-plist. http://bugs.python.org/issue19554
=20
-OPTIONS_DEFINE=3D		DEBUG IPV6 NLS PYMALLOC SEM THREADS
-OPTIONS_DEFAULT=3D	IPV6 NLS PYMALLOC SEM THREADS UCS4
+OPTIONS_DEFINE=3D		DEBUG IPV6 NLS PYMALLOC SEM THREADS PORT_FFI
+OPTIONS_DEFAULT=3D	IPV6 NLS PYMALLOC SEM THREADS UCS4 PORT_FFI
 OPTIONS_SINGLE=3D		UNICODE
 OPTIONS_SINGLE_UNICODE=3D	UCS2 UCS4
=20
=40=40 -45,6 +45,7 =40=40
 UCS2_DESC=3D	Enable UCS2 Unicode Strings
 UCS4_DESC=3D	Enable UCS4 Unicode Strings
 PYMALLOC_DESC=3D	Enable specialized mallocs
+PORT_FFI_DESC=3D	Use devel/ffi instead of ffi bundled with Python
=20
 DEBUG_CONFIGURE_WITH=3D	pydebug
 IPV6_CONFIGURE_ENABLE=3D	ipv6
=40=40 -88,6 +89,12 =40=40
 CFLAGS+=3D	-DPYTHON_DEFAULT_RECURSION_LIMIT=3D900
 .endif
=20
+.if =24=7BPORT_OPTIONS:MPORT_FFI=7D
+CONFIGURE_ARGS+=3D	--with-system-ffi
+BUILD_DEPENDS+=3D	libffi>=3D0:=24=7BPORTSDIR=7D/devel/libffi
+RUN_DEPENDS+=3D	libffi>=3D0:=24=7BPORTSDIR=7D/devel/libffi
+.endif
+
 =23 See http://bugs.freebsd.org/115940
 .if =21exists(/usr/bin/ypcat) =7C=7C defined(WITHOUT_NIS) =23 the world =
with NO_NIS
 PLIST_SUB+=3D	NO_NIS=3D=22=40comment =22
Index: python32/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- python32/Makefile	(revision 371620)
+++ python32/Makefile	(working copy)
=40=40 -2,7 +2,7 =40=40
=20
 PORTNAME=3D	python32
 PORTVERSION=3D	3.2.5
-PORTREVISION=3D	11
+PORTREVISION=3D	12
 CATEGORIES=3D	lang python ipv6
 MASTER_SITES=3D	PYTHON
 MASTER_SITE_SUBDIR=3D	ftp/python/=24=7BPORTVERSION=7D
=40=40 -33,13 +33,15 =40=40
 PLIST_SUB=3D		ABI=3D=24=7BABIFLAGS=7D =5C
 			OSMAJOR=3D=24=7BOSVERSION:C/(=5B0-9=5D*)=5B0-9=5D=7B5=7D/=5C1/=7D		=
=23 For plat-freebsd* in pkg-plist. http://bugs.python.org/issue19554
=20
-OPTIONS_DEFINE=3D		DEBUG IPV6 NLS PYMALLOC THREADS TSC UCS4
-OPTIONS_DEFAULT=3D	IPV6 NLS PYMALLOC THREADS UCS4
+OPTIONS_DEFINE=3D		DEBUG IPV6 NLS PYMALLOC THREADS TSC PORT_FFI
+OPTIONS_DEFAULT=3D	IPV6 NLS PYMALLOC THREADS PORT_FFI
+
 OPTIONS_SUB=3D		yes
=20
 NLS_DESC=3D		Enable gettext support for the locale module
 PYMALLOC_DESC=3D		Enable specialized mallocs
 TSC_DESC=3D		Enable processor timestamp counter profiling
+PORT_FFI_DESC=3D		Use devel/ffi instead of ffi bundled with Python
=20
 DEBUG_CONFIGURE_WITH=3D	pydebug
 IPV6_CONFIGURE_ENABLE=3D	ipv6
=40=40 -75,6 +77,12 =40=40
 ABIFLAGS:=3D		d=24=7BABIFLAGS=7D
 .endif
=20
+.if =24=7BPORT_OPTIONS:MPORT_FFI=7D
+CONFIGURE_ARGS+=3D	--with-system-ffi
+BUILD_DEPENDS+=3D  libffi>=3D0:=24=7BPORTSDIR=7D/devel/libffi
+RUN_DEPENDS+=3D    libffi>=3D0:=24=7BPORTSDIR=7D/devel/libffi
+.endif
+
 .if =21empty(ABIFLAGS)
 PLIST_FILES+=3D	bin/python3.2%%ABI%%
 PLIST_FILES+=3D	bin/python3.2%%ABI%%-config
Index: python33/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- python33/Makefile	(revision 371620)
+++ python33/Makefile	(working copy)
=40=40 -2,7 +2,7 =40=40
=20
 PORTNAME=3D	python33
 PORTVERSION=3D	3.3.5
-PORTREVISION=3D	4
+PORTREVISION=3D	5
 CATEGORIES=3D	lang python ipv6
 MASTER_SITES=3D	PYTHON
 MASTER_SITE_SUBDIR=3D	ftp/python/=24=7BPORTVERSION=7D
=40=40 -33,13 +33,15 =40=40
 PLIST_SUB=3D		ABI=3D=24=7BABIFLAGS=7D =5C
 			OSMAJOR=3D=24=7BOSVERSION:C/(=5B0-9=5D*)=5B0-9=5D=7B5=7D/=5C1/=7D		=
=23 For plat-freebsd* in pkg-plist. http://bugs.python.org/issue19554
=20
-OPTIONS_DEFINE=3D		DEBUG IPV6 NLS PYMALLOC THREADS TSC
-OPTIONS_DEFAULT=3D	IPV6 NLS PYMALLOC THREADS
+OPTIONS_DEFINE=3D		DEBUG IPV6 NLS PYMALLOC THREADS TSC PORT_FFI
+OPTIONS_DEFAULT=3D	IPV6 NLS PYMALLOC THREADS PORT_FFI
+
 OPTIONS_SUB=3D		yes
=20
 NLS_DESC=3D		Enable gettext support for the locale module
 PYMALLOC_DESC=3D		Enable specialized mallocs
 TSC_DESC=3D		Enable processor timestamp counter profiling
+PORT_FFI_DESC=3D		Use devel/ffi instead of ffi bundled with Python
=20
 DEBUG_CONFIGURE_WITH=3D	pydebug
 IPV6_CONFIGURE_ENABLE=3D	ipv6
=40=40 -69,6 +71,12 =40=40
 ABIFLAGS:=3D	d=24=7BABIFLAGS=7D
 .endif
=20
+.if =24=7BPORT_OPTIONS:MPORT_FFI=7D
+CONFIGURE_ARGS+=3D	--with-system-ffi
+BUILD_DEPENDS+=3D  libffi>=3D0:=24=7BPORTSDIR=7D/devel/libffi
+RUN_DEPENDS+=3D    libffi>=3D0:=24=7BPORTSDIR=7D/devel/libffi
+.endif
+
 .if =21empty(ABIFLAGS)
 PLIST_FILES+=3D	bin/python3.3%%ABI%%
 PLIST_FILES+=3D	bin/python3.3%%ABI%%-config
Index: python34/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- python34/Makefile	(revision 371620)
+++ python34/Makefile	(working copy)
=40=40 -3,6 +3,7 =40=40
=20
 PORTNAME=3D	python34
 PORTVERSION=3D	3.4.2
+PORTREVISION=3D	1
 CATEGORIES=3D	lang python ipv6
 MASTER_SITES=3D	PYTHON
 MASTER_SITE_SUBDIR=3D	ftp/python/=24=7BPORTVERSION=7D
=40=40 -34,8 +35,8 =40=40
 PLIST_SUB=3D		ABI=3D=24=7BABIFLAGS=7D =5C
 			OSMAJOR=3D=24=7BOSVERSION:C/(=5B0-9=5D*)=5B0-9=5D=7B5=7D/=5C1/=7D		=
=23 For plat-freebsd* in pkg-plist. http://bugs.python.org/issue19554
=20
-OPTIONS_DEFINE=3D		DEBUG IPV6 NLS PYMALLOC THREADS TSC
-OPTIONS_DEFAULT=3D	IPV6 NLS PYMALLOC THREADS
+OPTIONS_DEFINE=3D		DEBUG IPV6 NLS PYMALLOC THREADS TSC PORT_FFI
+OPTIONS_DEFAULT=3D	IPV6 NLS PYMALLOC THREADS PORT_FFI
 OPTIONS_RADIO=3D		HASH
 OPTIONS_RADIO_HASH=3D	FNV SIPHASH
 OPTIONS_SUB=3D		yes
=40=40 -43,6 +44,7 =40=40
 NLS_DESC=3D		Enable gettext support for the locale module
 PYMALLOC_DESC=3D		Enable specialized mallocs
 TSC_DESC=3D		Enable processor timestamp counter profiling
+PORT_FFI_DESC=3D		Use devel/ffi instead of ffi bundled with Python
=20
 HASH_DESC=3D		Hash Algorithm (PEP-456)
 FNV_DESC=3D		Modified Fowler-Noll-Vo Algorithm
=40=40 -78,6 +80,12 =40=40
 ABIFLAGS:=3D	d=24=7BABIFLAGS=7D
 .endif
=20
+.if =24=7BPORT_OPTIONS:MPORT_FFI=7D
+CONFIGURE_ARGS+=3D	--with-system-ffi
+BUILD_DEPENDS+=3D  libffi>=3D0:=24=7BPORTSDIR=7D/devel/libffi
+RUN_DEPENDS+=3D    libffi>=3D0:=24=7BPORTSDIR=7D/devel/libffi
+.endif
+
 .if =21empty(ABIFLAGS)
 PLIST_FILES+=3D	bin/python3.4%%ABI%%
 PLIST_FILES+=3D	bin/python3.4%%ABI%%-config

--==_Exmh_1414545361_49340
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Cheers,
Cy Schubert <Cy.Schubert=40komquats.com>
FreeBSD UNIX:  <cy=40FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.

--==_Exmh_1414545361_49340--





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201410290116.s9T1GjV2081414>