From owner-cvs-all@FreeBSD.ORG  Tue Mar  6 03:48:19 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8CCF516A401;
	Tue,  6 Mar 2007 03:48:19 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 624F113C46B;
	Tue,  6 Mar 2007 03:48:19 +0000 (UTC) (envelope-from sam@errno.com)
Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id l263m6pq091197
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 5 Mar 2007 19:48:07 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <45ECE475.1010405@errno.com>
Date: Mon, 05 Mar 2007 19:48:05 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 1.5.0.9 (X11/20070208)
MIME-Version: 1.0
To: Jeff Roberson <jroberson@chesapeake.net>
References: <200703042340.l24Neanq039195@repoman.freebsd.org>
	<20070306234936.O635@10.0.0.1>
In-Reply-To: <20070306234936.O635@10.0.0.1>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	"Wojciech A. Koszek" <wkoszek@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_alq.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Mar 2007 03:48:19 -0000

Jeff Roberson wrote:
> The ALQ lock is a spinlock.  I don't believe this works.  Do I
> misunderstand something?
> 
> On Sun, 4 Mar 2007, Wojciech A. Koszek wrote:
> 
>> wkoszek     2007-03-04 23:40:36 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/kern             kern_alq.c
>>  Log:
>>  Use msleep(9) instead of tsleep(9) surrounded by lock acquisition and
>>  release.
>>
>>  Approved by:    cognet (mentor)
>>
>>  Revision  Changes    Path
>>  1.17      +2 -6      src/sys/kern/kern_alq.c
>>
> 
> 

Yeah, this is totally busted and could never been tested.

	Sam