From owner-svn-ports-all@freebsd.org Sun Dec 16 05:44:37 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BEB27133DB60; Sun, 16 Dec 2018 05:44:37 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5CADD71787; Sun, 16 Dec 2018 05:44:37 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 2AF98E235; Sun, 16 Dec 2018 05:44:37 +0000 (UTC) From: Jan Beich To: Johannes M Dieterich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r487274 - head/graphics/drm-fbsd12.0-kmod References: <201812120223.wBC2NaiV060871@repo.freebsd.org> Date: Sun, 16 Dec 2018 06:44:33 +0100 In-Reply-To: <201812120223.wBC2NaiV060871@repo.freebsd.org> (Johannes M. Dieterich's message of "Wed, 12 Dec 2018 02:23:36 +0000 (UTC)") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 5CADD71787 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.32 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_SHORT(-0.87)[-0.873,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; NEURAL_HAM_MEDIUM(-0.99)[-0.986,0]; NEURAL_HAM_LONG(-0.46)[-0.458,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2018 05:44:37 -0000 Johannes M Dieterich writes: > Author: jmd > Date: Wed Dec 12 02:23:35 2018 > New Revision: 487274 > URL: https://svnweb.freebsd.org/changeset/ports/487274 > > Log: > graphics/drm-fbsd12.0: Update to 4.16 DRM > > Despite the improvements going from 4.11 to 4.16, it also > brings experimental support for i386 and powerpc64. > > Switch to dedicated upstream 12.0 branch > > Reviewed by: zeising (x11) > Differential Revision: https://reviews.freebsd.org/D18508 Fails to build on FreeBSD < 12. Did you forget to adjust OSVERSION check? http://beefy9.nyi.freebsd.org/data/112amd64-default/487333/logs/drm-fbsd12.0-kmod-4.16.g20181210.log http://beefy10.nyi.freebsd.org/data/112i386-default/487333/logs/drm-fbsd12.0-kmod-4.16.g20181210.log Copying ${OSVERSION} < 1200067 from drm-current-kmod won't do as only 12.0-RELEASE appears to be supported. For one, r335018 snapshot fails: In file included from include/drm/drmP.h:156: include/drm/drm_file.h:376:1: error: unknown type name '__poll_t'; did you mean 'd_poll_t'? __poll_t drm_poll(struct file *filp, struct poll_table_struct *wait); ^~~~~~~~ d_poll_t sys/sys/conf.h:122:13: note: 'd_poll_t' declared here typedef int d_poll_t(struct cdev *dev, int events, struct thread *td); ^ In file included from drivers/gpu/drm/ati_pcigart.c:35: In file included from include/drm/drmP.h:156: include/drm/drm_file.h:376:18: error: function cannot return function type 'd_poll_t' (aka 'int (struct cdev *, int, struct thread *)') __poll_t drm_poll(struct file *filp, struct poll_table_struct *wait); ^ 2 errors generated.