Date: Thu, 10 Aug 2006 11:55:42 -0600 From: John E Hein <jhein@timing.com> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: ports@FreeBSD.org, G?bor K?vesd?n <gabor@FreeBSD.org> Subject: Re: support for DESTDIR: security/openssh-portable Message-ID: <17627.29470.997143.560213@gromit.timing.com> In-Reply-To: <20060810140529.GB20275@lor.one-eyed-alien.net> References: <17626.25183.846983.515718@gromit.timing.com> <17626.25444.563099.956775@gromit.timing.com> <44DA6FC9.3040404@FreeBSD.org> <17626.29481.909830.326948@gromit.timing.com> <17626.30422.650339.960580@gromit.timing.com> <20060810132105.GA20275@lor.one-eyed-alien.net> <44DB33D2.4070308@FreeBSD.org> <20060810140529.GB20275@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Brooks Davis wrote at 09:05 -0500 on Aug 10, 2006:
> My inclination would be something like:
>
> PKG_INSTALL_TEMP=`mktemp ${DESTDIR}/tmp/pkg_install` && \
> (${CAT} ${PKG_INSTALL} > ${PKG_INSTALL_TEMP}; \
> ${SH} ${PKG_INSTALL_TEMP}; \
> ${RM} ${PKG_INSTALL_TEMP})
I would just put PKG_INSTALL_TEMP in WRKDIR and not worry about mktemp
& rm. I do something similar in my local tree for a pkg-install that
is slightly different when run from the 'install' target than the
one installed in PKG_DBDIR.
> I think we should ideally introduce a feature to allow ports to
> automatically run pkg-install and stuff the code in bsd.port.mk so
> ports don't have to know about DESTDIR in this case.
Yes. That'd be nice.
> Actually, ports where pkg-install and the pre/post-install targets
> duplicate code (often slightly differently) drive me nuts so I'd
> prefer a NO_AUTOPKGINSTALL, but that would take some real work so a
> positive flag is probably better initially.
Agreed. That duplication is definitely a candidate for cleanup.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17627.29470.997143.560213>