Date: Thu, 03 Jun 2004 23:09:47 +0200 From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=) To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h Message-ID: <xzp3c5c8i1w.fsf@dwp.des.no> In-Reply-To: <20040603.092954.114645644.imp@bsdimp.com> (M. Warner Losh's message of "Thu, 03 Jun 2004 09:29:54 -0600 (MDT)") References: <xzpy8n5knp1.fsf@dwp.des.no> <20040603.091250.82990500.imp@bsdimp.com> <xzp7juo8y8r.fsf@dwp.des.no> <20040603.092954.114645644.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"M. Warner Losh" <imp@bsdimp.com> writes:
> des@des.no (Dag-Erling Sm=F8rgrav) writes:
> : "M. Warner Losh" <imp@bsdimp.com> writes:
> : > How about an API? How does the driver deal with the global/instance
> : > variable split? If I set dev.fxp.gerbil to 1 and dev.fxp.1.gerbil to
> : > 23? Is that order dependent?
> : that's up to the driver author to decide.
> That's why I want to know the API the driver will use so that it can
> be judged as sufficient or not. I also think we should have some kind
> of default design pattern.
The API will be {devclass,device}_get_sysctl_{ctx,tree}(). The driver
then adds children to these nodes using sysctl_add_*().
> : you can't have the driver be the parent, because some devices have no
> : driver (but they all have a class), and I want to use dev.fxp.fxp0
> : instead of dev.fxp.0 on the off chance that there might be multiple
> : devices in a class with the same unit number but different names.
> That can't happen. If it does, I want other things to break as well
> so we notice when it does. I'd rather see symetry with the hints
> mechanism.
OK, I'll do dev.fxp.0.foo then.
DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzp3c5c8i1w.fsf>