From owner-svn-src-all@FreeBSD.ORG Tue Dec 2 05:12:01 2008 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B078106564A; Tue, 2 Dec 2008 05:12:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 497478FC16; Tue, 2 Dec 2008 05:12:01 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id mB25AbQq029486; Mon, 1 Dec 2008 22:10:37 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Mon, 01 Dec 2008 22:10:40 -0700 (MST) Message-Id: <20081201.221040.-1350500631.imp@bsdimp.com> To: alfred@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20081201132554.GD27096@elvis.mu.org> References: <49338E98.7020104@freebsd.org> <863ah8rvcd.fsf@ds4.des.no> <20081201132554.GD27096@elvis.mu.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, des@des.no, svn-src-all@FreeBSD.org, kientzle@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r185499 - head X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Dec 2008 05:12:01 -0000 In message: <20081201132554.GD27096@elvis.mu.org> Alfred Perlstein writes: : * Dag-Erling Sm??rgrav [081201 03:25] wrote: : > Tim Kientzle writes: : > > Alfred Perlstein writes: : > > > Log: : > > > Provide a 'tinderbox' target that compiles enough of FreeBSD that : > > > a developer can rest reasonably assured that the tinderbox will not : > > > be broken. This target leverages most of 'universe' but will exit : > > > non-zero and output a summary at the end. : > > > "make tinderbox" : > > Excellent! : > : > I really don't see the point, especially now that 'make universe' will : > issue a warning on stdout for every build that fails. As I've tried to : > explain to Alfred, the tinderbox does nothing magical, and nothing that : > isn't already covered by 'make universe'. I also asked him to discuss : > any changes with Poul-Henning before committing them. : : I'll summarize the changes here: : : Problems with make universe: : 1) Make universe returns success on failure. : 2) Make universe outputs the following on failure: : -------------------------------------------------------------- : make universe completed on `LC_ALL=C date`" : (started ${STARTTIME})" : -------------------------------------------------------------- : : This basically means you can't chain 'make universe' into something : like "make tinderbox || (echo oops | mail -s tinderbox failed...)". : : The summary at the end "completed" is very misleading. : : The tinderbox target differs as follows: : : It returns an error if it fails. : It outputs a summary of the failures at the end. : The name reflects what its for. ("what the heck is a universe?") : : : If you strongly believe that a target should return "true" on failure : and/or output "i worked" on failure then I'm not sure how to approach : that mindset, maybe you can help me understand where you're coming from : on that? Where is the utility in it? Is there something I'm missing? I think you ignored the discussions that said that 'universe' should be modified to exit with an error when there was an error, but shouldn't bail out EARLY. There were even patches to do this. Based on that, why do something completely new and different? Warner