From owner-freebsd-emulation@FreeBSD.ORG Thu Nov 21 19:10:02 2013 Return-Path: Delivered-To: vbox@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1CF44623 for ; Thu, 21 Nov 2013 19:10:02 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E6A3F2DC2 for ; Thu, 21 Nov 2013 19:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rALJA1ii048673 for ; Thu, 21 Nov 2013 19:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rALJA1gU048672; Thu, 21 Nov 2013 19:10:01 GMT (envelope-from gnats) Date: Thu, 21 Nov 2013 19:10:01 GMT Message-Id: <201311211910.rALJA1gU048672@freefall.freebsd.org> To: vbox@FreeBSD.org From: Peter Jeremy Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose X-Mailman-Approved-At: Thu, 21 Nov 2013 22:06:27 +0000 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list Reply-To: Peter Jeremy List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 19:10:02 -0000 The following reply was made to PR ports/182468; it has been noted by GNATS. From: Peter Jeremy To: Eitan Adler Cc: Bernhard =?iso-8859-1?Q?Fr=F6hlich?= , bug-followup , vbox@freebsd.org Subject: Re: ports/182468: [patch] lang/gcc builds unrunnable emulators/virtualbox-ose Date: Fri, 22 Nov 2013 06:01:34 +1100 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2013-Nov-17 16:32:46 -0500, Eitan Adler wrote: >On Wed, Nov 13, 2013 at 7:40 AM, Bernhard Fr=F6hlich w= rote: >> I think the idea and approach is correct but I went for a slighly more >> conservative >> approach if _GCC_RUNTIME was not set which is true in case base gcc is = used=3D > >This can not possibly be correct as the variable begins with a "_". >The initial proposed patch is also incorrect for a similar reason. >_GCC_RUNTIME is not valid for use in a ports Makefile. I completely agree. As I initially stated, this is solely a work- around for a bug in lang/gcc*. In fact the existing use of _GCC_RUNTIME in bsd.gcc.mk is equally wrong and is also just a work- around for lang/gcc* bugs. >Perhaps it would help if USE_GCC or USES=3Dcompiler exposed a variable >indicating the runtime? This is not correct either. A port using lang/gcc should not need to know about the compiler internals. If code compiled with gcc46 needs to be linked against non-standard libraries then using gcc46 for linking should be sufficient - it shouldn't be necessary to add magic "-Wl,-rpath=3D..." options. (IMO, the whole -L/-rpath approach is broken: The runtime searchpath should default to the linktime searchpath. Unfortunately, fixing that isn't possible). --=20 Peter Jeremy --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iKYEARECAGYFAlKOWI1fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDBCRjc3QTcyNTg5NEVCRTY0RjREN0VFRUZF OEE0N0JGRjAwRkI4ODcACgkQ/opHv/APuIcR4QCguG7m2cfWIDQ7Rihzecsp53yQ J60An1ZMVu/0W52xOuKz6COp96SYAyfs =49pK -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs--