From owner-freebsd-hackers@FreeBSD.ORG Sun Apr 6 11:54:34 2003 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 287F337B404 for ; Sun, 6 Apr 2003 11:54:34 -0700 (PDT) Received: from mx02.uni-tuebingen.de (mx02.uni-tuebingen.de [134.2.3.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DAF943FBF for ; Sun, 6 Apr 2003 11:54:32 -0700 (PDT) (envelope-from friedemann.becker@student.uni-tuebingen.de) Received: from linux17.zdv.uni-tuebingen.de (linux17.zdv.uni-tuebingen.de [134.2.18.17]) by mx02.uni-tuebingen.de (8.12.3/8.12.3) with ESMTP id h36IsUR0025268 for ; Sun, 6 Apr 2003 20:54:30 +0200 Date: Sun, 6 Apr 2003 20:54:29 +0200 (CEST) From: Friedemann Becker X-Sender: To: In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="42340626-1943708896-1049655269=:10665" X-AntiVirus: checked by AntiVir Milter 1.0.0.8; AVE 6.19.0.3; VDF 6.19.0.5 Subject: Re: [PATCH] Re: systat -v on -CURRENT X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Apr 2003 18:54:34 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --42340626-1943708896-1049655269=:10665 Content-Type: TEXT/PLAIN; charset=US-ASCII Never talk about patches that you'll forget to attach ;) On Sun, 6 Apr 2003, Friedemann Becker wrote: > Date: Sun, 6 Apr 2003 20:52:11 +0200 (CEST) > From: Friedemann Becker > To: freebsd-hackers@freebsd.org > Subject: [PATCH] Re: systat -v on -CURRENT > > I found out, that /usr/src/usr.bin/systat/vmstat.c:dinfo() sometimes > calculates -0 for disk utilization. > > I attatched a patch, that fixed this behaviour and return 0 for negative > values of "elapsed time". > > Could someone take a look at it and commit it, if it's correct? > it's a one line + 2 lines of comment patch :-) > > Friedemann > > > > On Sat, 5 Apr 2003, Craig Reyenga wrote: > > > Date: Sat, 5 Apr 2003 17:34:51 -0500 > > From: Craig Reyenga > > To: Andre Guibert de Bruet > > Cc: freebsd-current@freebsd.org > > Subject: Re: systat -v on -CURRENT > > > > Now that you mention it, Yes: ad2 is -0% busy. > > > > Disks ad0 ad2 cd0 pass0 ofod intrn > > KB/t 0.00 0.00 0.00 0.00 %slo-z 30576 buf > > tps 0 0 0 0 tfree 23 dirtybuf > > MB/s 0.00 0.00 0.00 0.00 17867 desiredvnodes > > % busy 0 -0 0 0 1070 numvnodes > > > > -Craig > > > > ----- Original Message ----- > > From: "Andre Guibert de Bruet" > > To: > > Sent: Saturday, April 05, 2003 5:20 PM > > Subject: systat -v on -CURRENT > > > > > > > Hi, > > > > > > I've noticed that 'systat -v' sometimes reports a negative disk activity > > > percentile. Has anyone else noticed this behavior? > > > > > > Before I look into the problem, is someone already working on a fix? > > > > > > Regards, > > > > > > > Andre Guibert de Bruet | Enterprise Software Consultant > > > > > Silicon Landmark, LLC. | http://siliconlandmark.com/ > > > > _______________________________________________ > > > freebsd-current@freebsd.org mailing list > > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > > > > > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > > > --42340626-1943708896-1049655269=:10665 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="vmstat.c.patch" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: /usr/src/usr.bin/systat/vmstat.c patch Content-Disposition: attachment; filename="vmstat.c.patch" LS0tIHZtc3RhdC5jCVN1biBBcHIgIDYgMjA6NDY6MDggMjAwMw0KKysrIHZt c3RhdC5jLm9sZAlTdW4gQXByICA2IDE4OjQ0OjU1IDIwMDMNCkBAIC04Nzgs MTEgKzg3OCw2IEBADQogCQkgKiB3aGVyZSB0aGUgZGV2aWNlIGhhcyBiZWVu IDEwMCUgYnVzeSwgY29ycmVjdCBpdCAqLw0KIAkJZGV2aWNlX2J1c3kgPSBl bGFwc2VkX3RpbWU7DQogDQotCWlmIChkZXZpY2VfYnVzeSA8IDApDQotCQkv KiBkZXZpY2VfYnVzeSBzb21ldGltZXMgYmVjb21lcyAtMCwgc28gY3V0IG9m ZiBuZWdhdGl2ZQ0KLQkJICogdmFsdWVzICovDQotCSAgZGV2aWNlX2J1c3kg PSAwOw0KLQ0KIAlsYyA9IERJU0tDT0wgKyBsYyAqIDY7DQogCXB1dGxvbmdk b3VibGUoa2JfcGVyX3RyYW5zZmVyLCBESVNLUk9XICsgMSwgbGMsIDUsIDIs IDApOw0KIAlwdXRsb25nZG91YmxlKHRyYW5zZmVyc19wZXJfc2Vjb25kLCBE SVNLUk9XICsgMiwgbGMsIDUsIDAsIDApOw0K --42340626-1943708896-1049655269=:10665--