From owner-freebsd-stable  Sat Sep 14 20:31:29 2002
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7456E37B400; Sat, 14 Sep 2002 20:31:27 -0700 (PDT)
Received: from lerlaptop.lerctr.org (lerlaptop.lerctr.org [207.158.72.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CA92D43E6E; Sat, 14 Sep 2002 20:31:26 -0700 (PDT)
	(envelope-from ler@lerctr.org)
Received: from localhost (localhost [127.0.0.1])
	by lerlaptop.lerctr.org (8.12.6/8.12.5) with ESMTP id g8F3VJKo001531;
	Sat, 14 Sep 2002 22:31:19 -0500 (CDT)
	(envelope-from ler@lerctr.org)
Subject: RE: missing break in recent patch to agp_i810.c
From: Larry Rosenman <ler@lerctr.org>
To: John Baldwin <jhb@FreeBSD.ORG>
Cc: Tim Zingelman <zingelman@fnal.gov>, stable@FreeBSD.ORG,
	re@FreeBSD.ORG, anholt@FreeBSD.ORG
In-Reply-To: <XFMail.20020914231802.jhb@FreeBSD.org>
References: <XFMail.20020914231802.jhb@FreeBSD.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Ximian Evolution 1.0.8 
Date: 14 Sep 2002 22:31:19 -0500
Message-Id: <1032060680.1397.0.camel@lerlaptop.lerctr.org>
Mime-Version: 1.0
X-Virus-Scanned: by amavisd-milter (http://amavis.org/)
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG

On Sat, 2002-09-14 at 22:18, John Baldwin wrote:
> 
> On 15-Sep-2002 Tim Zingelman wrote:
> > My I810 system broke and gave this message...
> > 
> >  agp0: unknown memory configuration, disabling
> >  device_probe_and_attach: agp0 attach returned 22
> > 
> > with the 1.1.2.4 revision of agp_i810.c.  A little investigation shows
> > there is clearly a missing 'break;' in a switch statement.  The following
> > patch fixes it.
> > 
> > --- agp_i810.c.RELENG_4 Sat Sep 14 19:27:10 2002
> > +++ agp_i810.c  Sat Sep 14 20:56:16 2002
> > @@ -219,6 +219,7 @@
> >         case 0x71258086:
> >         case 0x11328086:
> >                 sc->chiptype = CHIP_I810;
> > +               break;
> >         case 0x35778086:
> >         case 0x25628086:
> >                 sc->chiptype = CHIP_I830;
> > 
> > Release engineering please consider commit approval for this fix.
> 
> Certainly!  Approved conditional on Eric's consent.  Thanks for testing
> this and tracking this down.
It also does NOT break the I830 support.  Please commit....

-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 972-414-9812                 E-Mail: ler@lerctr.org
US Mail: 1905 Steamboat Springs Drive, Garland, TX 75044-6749


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message