From owner-freebsd-current Sun Feb 15 15:25:56 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id PAA12451 for freebsd-current-outgoing; Sun, 15 Feb 1998 15:25:56 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id PAA12429 for ; Sun, 15 Feb 1998 15:25:51 -0800 (PST) (envelope-from grog@lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.8.7/8.8.5) with ESMTP id JAA25575; Mon, 16 Feb 1998 09:55:20 +1030 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.8.8/8.8.7) id JAA20590; Mon, 16 Feb 1998 09:55:20 +1030 (CST) (envelope-from grog) Message-ID: <19980216095519.33042@freebie.lemis.com> Date: Mon, 16 Feb 1998 09:55:19 +1030 From: Greg Lehey To: "Jordan K. Hubbard" Cc: Chris Csanady , freebsd-current@FreeBSD.ORG Subject: Re: CCD missing spl() call.. References: <19980216075421.52560@freebie.lemis.com> <16771.887583090@time.cdrom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89i In-Reply-To: <16771.887583090@time.cdrom.com>; from Jordan K. Hubbard on Sun, Feb 15, 1998 at 02:51:30PM -0800 WWW-Home-Page: http://www.lemis.com/~grog Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 15 February 1998 at 14:51:30 -0800, Jordan K. Hubbard wrote: >> I don't know what function you were referring to, since you don't >> mention the name. All I have to go on is the original patch: > > ccdintr(). > >> This patch definitely applies to ccdiodone. Look at the text in the > > Odd, for me it applied to ccdintr() with lots of fuzz. :-) Presumably because the modification was already in there. Certainly it was wrong where it put it. Consider the patch: *************** *** 973,978 **** --- 973,979 ---- register int unit = cbp->cb_unit; int count, s; + s = splbio(); #ifdef DEBUG if (ccddebug & CCDB_FOLLOW) printf("ccdiodone(%x)\n", cbp); Hunk #2 succeeded at 938 with fuzz 2 (offset -35 lines). What it did was: --- ccd.c 1998/01/31 03:19:06 1.28 +++ ccd.c 1998/02/15 23:20:43 @@ -938,6 +938,7 @@ register struct buf *bp; { + s = splbio(); #ifdef DEBUG if (ccddebug & CCDB_FOLLOW) printf("ccdintr(%x, %x)\n", cs, bp); That's a little too fuzzy for my liking. Greg To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message