From owner-freebsd-ports@freebsd.org Mon Jun 27 11:52:32 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D573BB82F0E for ; Mon, 27 Jun 2016 11:52:32 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id B08602ACF for ; Mon, 27 Jun 2016 11:52:32 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id AFD32B82F0A; Mon, 27 Jun 2016 11:52:32 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA970B82F09; Mon, 27 Jun 2016 11:52:32 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6BF262ACD; Mon, 27 Jun 2016 11:52:32 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf0-x231.google.com with SMTP id i123so61429070pfg.0; Mon, 27 Jun 2016 04:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=EycICaEdjhTo//l/OAJVyQciL0wOLLoWWSCTk+n3odM=; b=htpkuJqld8BdhBr98P57wsEs7fE5hYSSNZViyeQeu3g9WXuyvjqlvcRzJUTsWs4KiU /GFK2wWjzVcGLKIwUSPBgUS7riJc3us3ovI09TOLll97RcoGAdzyXs3GWsWN5gxEbX9Y 1UFZ4VlZkGDQ8iUOgCzCIDuNJtjSW3tFyD4oN/5jhHEZ00M7kf108PdcOH5NM9uNpGJ2 /lfjV/fELOEk8k20cCpynQ3fjrn9iZz1f5liOaRujstT+vAuCOGgYt2eKuGsG9H00Z2I RwCD46TNQQOZ0PiNaWR3sI5POuEYLuw+TvoLgqDl2RzS3Dw3NO6UBw18w5Dm8SaDUzAS 7GhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:reply-to:subject:references:to:cc:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=EycICaEdjhTo//l/OAJVyQciL0wOLLoWWSCTk+n3odM=; b=DEbEPfy2mH9xY+uCr9byBEjEkAS+ysjDhk0QjTloDfWnZw18NH66Q2gmSKm3hxvShh 49kWQbW6bU2MF8tbRc/CfZFa8eWaNFVXkhQw25jnSQI/yq/9B0xpMMfDefQ33aIBabsy St50awly7N2x8wWw/RgH2oJD46GdkYBd4Myf3VfZEg9w9ZGQd1dY4Hy2g6PJ5UhDlc7P nM5XTMdEGjorasulKAooLL6PkSZr/ipYJmeXVN+dHahlPugSgDDQ2R/X8hxHmWL/IzS4 p0lpUv1cdyZLO6gPcPbYICHuN1/NNCbv30FDW5RffKEjtbxXmMN/mzTQ2EnuhC7nla0a 6+hg== X-Gm-Message-State: ALyK8tIg4pWaqp3oY/EBldKdt5DN0UGvQrYPuh+ejxB3jQhbgzsjmO6tOG/pvyk24IKmdQ== X-Received: by 10.98.103.66 with SMTP id b63mr32994714pfc.141.1467028351757; Mon, 27 Jun 2016 04:52:31 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:6866:ec26:8c89:33cf? (2001-44b8-31ae-7b01-6866-ec26-8c89-33cf.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:6866:ec26:8c89:33cf]) by smtp.gmail.com with ESMTPSA id b186sm6216458pfa.61.2016.06.27.04.52.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jun 2016 04:52:31 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: pkg SAT_SOLVER bugs References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> To: Hans Petter Selasky , Slawa Olhovchenkov , Baptiste Daroussin Cc: ports@FreeBSD.org, FreeBSD Current From: Kubilay Kocak Message-ID: <44a43ec3-4f64-3de6-4f48-cb1b7231f9a2@FreeBSD.org> Date: Mon, 27 Jun 2016 21:52:23 +1000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Thunderbird/47.0 MIME-Version: 1.0 In-Reply-To: <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 11:52:32 -0000 On 27/06/2016 8:38 PM, Hans Petter Selasky wrote: > Hi, > > I found some bugs in PKG with regard to the SAT_SOLVER environment > variable. Please find patch attached :-) Nice! Can you report upstream @ https://github.com/freebsd/pkg if you haven't already > Issues fixed: > 1) No need to use hash table when generating SAT rules for external > solver. Variables are already in a linear array. Fix encoding and > decoding of SAT data. > 2) Endless variable loop caused pkg to crash. > 3) it->inverse was checked for non-zero, while it should actually be > checked for -1 only. SAT rules produces were all negative. > > How to verify: > > make -C /usr/ports/math/picosat all install clean > > env SAT_SOLVER=picosat pkg upgrade > > --HPS