From owner-freebsd-bugs@freebsd.org Sun Feb 14 11:25:33 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1948152BD81 for ; Sun, 14 Feb 2021 11:25:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DdlK903Q9z4v7v for ; Sun, 14 Feb 2021 11:25:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 01DCC52B9F1; Sun, 14 Feb 2021 11:25:33 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 01A4252BD0A for ; Sun, 14 Feb 2021 11:25:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DdlK86Wtmz4vSS for ; Sun, 14 Feb 2021 11:25:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D3011FFC for ; Sun, 14 Feb 2021 11:25:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11EBPW05083519 for ; Sun, 14 Feb 2021 11:25:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11EBPWxQ083518 for bugs@FreeBSD.org; Sun, 14 Feb 2021 11:25:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 253500] fusefs: F_SETLKW fcntl gets corrupted by kern_fcntl() Date: Sun, 14 Feb 2021 11:25:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jmillikin@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2021 11:25:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253500 Bug ID: 253500 Summary: fusefs: F_SETLKW fcntl gets corrupted by kern_fcntl() Product: Base System Version: 12.2-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: jmillikin@gmail.com Created attachment 222425 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D222425&action= =3Dedit quick-n-dirty patch to fix fcntl locking in FUSE There's at least two bugs in fcntl lock handling that get tickled by FUSE: 1. Calls to `fcntl(fd, F_SETLKW, &lock)` are showing up in the FUSE serve= r as a FUSE_SETLK (should be FUSE_SETLKW). 2. fcntl calls to _clear_ a lock, by using F_SETLK with `l_type =3D F_UNL= CK`, never get passed to userspace at all. It looks like both incorrect behaviors are caused by `kern_fcntl()`: * F_SETLKW is handled by a switch-case fallthrough to the F_SETLK path, b= ut the `VOP_ADVLOCK()' call is hardcoded to use `F_SETLK'. * In the nested switch over the lock type, several calls to `VOP_ADVLOCK(= )' are performed using the lock type (e.g. `F_UNLCK') where they should use the fcntl opcode. This causes `fuse_vnop_advlock()' to return EINVAL. Attached is a patch that fixes both issues according to my test suite. I'm = not very familiar with the FreeBSD kernel, so note that this patch might not do= the right thing for other filesystem drivers. --=20 You are receiving this mail because: You are the assignee for the bug.=