From owner-freebsd-bugs@FreeBSD.ORG Thu Jun 5 22:46:30 2003 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D17837B401 for ; Thu, 5 Jun 2003 22:46:30 -0700 (PDT) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9EB3843F93 for ; Thu, 5 Jun 2003 22:46:28 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 35DEC51A7C; Fri, 6 Jun 2003 15:16:26 +0930 (CST) Date: Fri, 6 Jun 2003 15:16:26 +0930 From: Greg 'groggy' Lehey To: freebsd-bugs@FreeBSD.org Message-ID: <20030606054626.GD72838@wantadilla.lemis.com> References: <200306060530.h565UEFs038804@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SO98HVl1bnMOfKZd" Content-Disposition: inline In-Reply-To: <200306060530.h565UEFs038804@freefall.freebsd.org> User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Subject: Re: kern/52916: vinum causes panic after start/stop/... cycle, easy to reproduce X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2003 05:46:30 -0000 --SO98HVl1bnMOfKZd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thursday, 5 June 2003 at 22:30:14 -0700, Greg 'groggy' Lehey wrote: > > I'm guessing this has something to do with md devices. Do you use > any? I don't, and every 'vinum start' created one. I've committed a > fix to vinum(8) (revision 1.31.2.6 of src/sbin/vinum/commands.c). > Please try it and tell me if it fixes the problem. Here it is again > to save you cvsupping: > > diff -w -u -r1.31.2.5 commands.c > --- commands.c 4 May 2002 05:04:14 -0000 1.31.2.5 > +++ commands.c 6 Jun 2003 05:08:43 -0000 > @@ -275,6 +275,10 @@ > char reply[32]; > int error; > =20 > + if (! isatty (STDIN_FILENO)) { > + fprintf (stderr, "Please enter this command from a tty device\n"); > + return; > + } > printf(" WARNING! This command will completely wipe out your vinum co= > nfiguration.\n" > " All data will be lost. If you really want to do this, enter the = > text\n\n" > " NO FUTURE\n" Ugh. Did GNATS do that? Anyway, don't bother. I can now reproduce the problem more easily :-( Greg -- See complete headers for address and phone numbers --SO98HVl1bnMOfKZd Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE+4CqyIubykFB6QiMRAr2AAJ0VT/xDZlVcSQfWKpQSz/OuMfa83wCdGPD2 tGKAWhgGR+rPELzsEZ9VR4M= =Y//I -----END PGP SIGNATURE----- --SO98HVl1bnMOfKZd--