From owner-cvs-all@FreeBSD.ORG Tue Jun 9 18:39:16 2009 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C9947106566B; Tue, 9 Jun 2009 18:39:16 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.60.158]) by mx1.freebsd.org (Postfix) with ESMTP id A12818FC17; Tue, 9 Jun 2009 18:39:16 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: by syn.atarininja.org (Postfix, from userid 1001) id 3385D5C40; Tue, 9 Jun 2009 14:39:16 -0400 (EDT) Date: Tue, 9 Jun 2009 14:39:16 -0400 From: Wesley Shields To: Doug Barton Message-ID: <20090609183916.GA40713@atarininja.org> References: <200906091346.n59Dk3vj093458@repoman.freebsd.org> <4A2EA0A1.6010607@FreeBSD.org> <20090609180020.GA40405@atarininja.org> <4A2EAB3B.6040205@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A2EAB3B.6040205@FreeBSD.org> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports UPDATING X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2009 18:39:17 -0000 On Tue, Jun 09, 2009 at 11:34:35AM -0700, Doug Barton wrote: > Wesley Shields wrote: > > The problem was not with portmaster, > > That's always good news. :) > > > but was with the reliance on > > pkg_which. The attached patch should fit it. I currently have sent it > > to itetcu and miwi for review. The biggest downside is that pkg_info can > > not take multiple arguments on the command line like pkg_which does, so > > we have to use xargs -L 1, which makes things slow compared to using > > pkg_which. > > Have you benchmarked that? I would imagine (although I don't know for > sure) that pkg_which is just calling whatever method it uses to get > the answer once each time for each command line argument, which would > mean that they are basically equivalent. No I have not run any tests so I could be entirely wrong there. Either way, I don't think it's that big of a deal. I just wanted something that worked with portmaster so I don't have to install portupgrade and it's dependencies just to update python. > It seems that the current solution is needlessly complicated (although > I haven't benchmarked either). What would be wrong with something like: > > for file in `find -type f`; do > pkg_info -qW $file > done | sort -u I agree, it can likely be simplified quite a bit. This was just a quick hack to get something working for those of us who use portmaster and not portupgrade. -- WXS