Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Mar 2004 23:48:22 -0800 (PST)
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 48690 for review
Message-ID:  <200403110748.i2B7mMj5028496@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=48690

Change 48690 by marcel@marcel_nfs on 2004/03/10 23:48:02

	Add missing #include <sys/kdb.h> and fix initialization of
	KDB. LINT compiles on alpha.

Affected files ...

.. //depot/projects/gdb/sys/alpha/alpha/interrupt.c#3 edit
.. //depot/projects/gdb/sys/alpha/alpha/machdep.c#4 edit
.. //depot/projects/gdb/sys/alpha/alpha/trap.c#3 edit

Differences ...

==== //depot/projects/gdb/sys/alpha/alpha/interrupt.c#3 (text+ko) ====

@@ -41,6 +41,7 @@
 #include <sys/systm.h>
 #include <sys/bus.h>
 #include <sys/interrupt.h>
+#include <sys/kdb.h>
 #include <sys/kernel.h>
 #include <sys/ktr.h>
 #include <sys/lock.h>

==== //depot/projects/gdb/sys/alpha/alpha/machdep.c#4 (text+ko) ====

@@ -100,6 +100,7 @@
 #include <sys/systm.h>
 #include <sys/eventhandler.h>
 #include <sys/imgact.h>
+#include <sys/kdb.h>
 #include <sys/sysproto.h>
 #include <sys/ktr.h>
 #include <sys/signalvar.h>
@@ -1026,12 +1027,11 @@
 	/*
 	 * Initialize debuggers, and break into them if appropriate.
 	 */
-#ifdef DDB
 	kdb_init();
-	if (boothowto & RB_KDB) {
-		printf("Boot flags requested debugger\n");
-		breakpoint();
-	}
+
+#ifdef KDB
+	if (boothowto & RB_KDB)
+		kdb_enter("Boot flags requested debugger\n");
 #endif
 
 	/*

==== //depot/projects/gdb/sys/alpha/alpha/trap.c#3 (text+ko) ====

@@ -35,6 +35,7 @@
 
 #include <sys/param.h>
 #include <sys/systm.h>
+#include <sys/kdb.h>
 #include <sys/ktr.h>
 #include <sys/sysproto.h>
 #include <sys/kernel.h>
@@ -67,9 +68,6 @@
 #include <sys/ktrace.h>
 #endif
 
-#ifdef DDB
-#include <ddb/ddb.h>
-#endif
 #include <alpha/alpha/db_instruction.h>		/* for handle_opdec() */
 
 unsigned long	Sfloat_to_reg(unsigned int);
@@ -367,7 +365,7 @@
 		 * These are always fatal in kernel, and should never happen.
 		 */
 		if (!user) {
-#ifdef DDB
+#ifdef KDB
 			/*
 			 * ...unless, of course, DDB is configured; BUGCHK
 			 * is used to invoke the kernel debugger, and we



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403110748.i2B7mMj5028496>