From owner-freebsd-current  Sat Apr  5 02:08:33 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id CAA00585
          for current-outgoing; Sat, 5 Apr 1997 02:08:33 -0800 (PST)
Received: from hda.hda.com (hda-bicnet.bicnet.net [207.198.1.121])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id CAA00580
          for <current@freebsd.org>; Sat, 5 Apr 1997 02:08:26 -0800 (PST)
Received: (from dufault@localhost)
	by hda.hda.com (8.8.5/8.8.5) id FAA08421
	for current@freebsd.org; Sat, 5 Apr 1997 05:06:04 -0500 (EST)
From: Peter Dufault <dufault@hda.com>
Message-Id: <199704051006.FAA08421@hda.hda.com>
Subject: Breaking the lkm DISPATCH macro
To: current@freebsd.org
Date: Sat, 5 Apr 1997 05:06:03 -0500 (EST)
X-Mailer: ELM [version 2.4ME+ PL25 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

Heads up:

I'm about to break LKM's DISPATCH macro by passing in the name
argument.  LKM's are broken in -current for MOD_DEV, and in fixing
them I want to eliminate the static _module structure by prepending
the name.

This can't be done compatably (without cruft like feature test macros)
since DISPATCH uses _module directly and the new MOD_DECL functions
will prepend the name.

The interface change will require changing DISPATCH to
MOD_DISPATCH (gratuitous for consistency with the other macros)
and passing the name in.  I'm keeping a DISPATCH macro there to
generate an error that leads back to the header to see what changed.

I've fixed the code in the tree but user LKMs in -current will break.
They're already broken in -current versus non -current since the name
argument has changed from a string to an identifier so I think that
is a minor issue.

Bruce reviewed the changes.

-- 
Peter Dufault (dufault@hda.com)   Realtime Machine Control and Simulation
HD Associates, Inc.               Voice: 508 433 6936