From owner-svn-src-head@freebsd.org  Wed Dec 27 21:56:04 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B586CE8040E;
 Wed, 27 Dec 2017 21:56:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9455179F30;
 Wed, 27 Dec 2017 21:56:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro-5.local
 (astound-66-234-202-155.ca.astound.net [66.234.202.155])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 06F5810A8C2;
 Wed, 27 Dec 2017 16:56:02 -0500 (EST)
Subject: Re: svn commit: r327166 - head/sys/x86/isa
To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201712241759.vBOHxm5d005082@repo.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <d803faa8-e361-4c99-9d57-537503dc4266@FreeBSD.org>
Date: Wed, 27 Dec 2017 13:56:01 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <201712241759.vBOHxm5d005082@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Wed, 27 Dec 2017 16:56:03 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Dec 2017 21:56:04 -0000

On 12/24/17 9:59 AM, Warner Losh wrote:
> Author: imp
> Date: Sun Dec 24 17:59:48 2017
> New Revision: 327166
> URL: https://svnweb.freebsd.org/changeset/base/327166
> 
> Log:
>   Further investigation shows this shouldn't have been added at all.
>   Remove it.
> 
> Modified:
>   head/sys/x86/isa/orm.c
> 
> Modified: head/sys/x86/isa/orm.c
> ==============================================================================
> --- head/sys/x86/isa/orm.c	Sun Dec 24 16:53:55 2017	(r327165)
> +++ head/sys/x86/isa/orm.c	Sun Dec 24 17:59:48 2017	(r327166)
> @@ -156,7 +156,6 @@ orm_identify(driver_t* driver, device_t parent)
>  		device_set_desc(child, "ISA Option ROM");
>  	else
>  		device_set_desc(child, "ISA Option ROMs");
> -//	isa_set_vendorid(child, PNP_EISAID("PNP0C80"));
>  }

So does this mean orm0 will trigger warnings in GENERIC now?

-- 
John Baldwin