Date: Wed, 22 Jan 2003 14:00:58 -0500 (EST) From: Ken Smith <kensmith@dcsl.Buffalo.EDU> To: FreeBSD-gnats-submit@FreeBSD.org Cc: kensmith@dcsl.Buffalo.EDU Subject: kern/47372: vinum driver creates /dev entries with wrong group/perms Message-ID: <200301221900.h0MJ0wkI000724@mack.dcsl.buffalo.edu>
next in thread | raw e-mail | index | archive | help
>Number: 47372
>Category: kern
>Synopsis: vinum driver creates /dev entries with wrong group/perms
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jan 22 11:10:01 PST 2003
>Closed-Date:
>Last-Modified:
>Originator: Ken Smith
>Release: FreeBSD 5.0-RELEASE i386
>Organization:
U. Buffalo CSE Department
>Environment:
System: FreeBSD mack.dcsl.Buffalo.EDU 5.0-RELEASE FreeBSD 5.0-RELEASE #1: Wed Jan 22 13:28:07 EST 2003 root@mack.dcsl.Buffalo.EDU:/usr/src/sys/i386/compile/MACK i386
>Description:
All disk devices are in group operator and group-readable so things
like Amanda can run as non-privileged users. The vinum driver
creates its /dev/vinum devices in group wheel with no group
readability permissions.
>How-To-Repeat:
Set up a vinum based volume, change the group ownership and permissions
manually, then reboot. Now that devfs is being used the changes
don't survive a reboot.
>Fix:
Patch attached below for file in /usr/src/sys/dev/vinum. It seemed
to work fine on my system...
*** vinumconfig.c_dist Thu Dec 12 19:27:32 2002
--- vinumconfig.c Wed Jan 22 13:27:53 2003
***************
*** 1564,1571 ****
vol->dev = make_dev(&vinum_cdevsw,
VINUMRMINOR(volno, VINUM_VOLUME_TYPE),
UID_ROOT,
! GID_WHEEL,
! S_IRUSR | S_IWUSR,
"vinum/%s",
vol->name);
}
--- 1564,1571 ----
vol->dev = make_dev(&vinum_cdevsw,
VINUMRMINOR(volno, VINUM_VOLUME_TYPE),
UID_ROOT,
! GID_OPERATOR,
! S_IRUSR | S_IWUSR | S_IRGRP,
"vinum/%s",
vol->name);
}
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301221900.h0MJ0wkI000724>