From owner-cvs-src@FreeBSD.ORG Thu Nov 10 07:03:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F014816A420; Thu, 10 Nov 2005 07:03:15 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 83CE443D48; Thu, 10 Nov 2005 07:03:15 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 77A13BC66; Thu, 10 Nov 2005 07:03:13 +0000 (UTC) To: Doug White From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 09 Nov 2005 22:59:35 PST." <20051109225823.Y62099@carver.gumbysoft.com> Date: Thu, 10 Nov 2005 08:03:13 +0100 Message-ID: <3515.1131606193@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: Doug White , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c src/sys/fs/devfs devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2005 07:03:16 -0000 In message <20051109225823.Y62099@carver.gumbysoft.com>, Doug White writes: >> The proper fix is to put the cookie in the dirent and abandon the >> microoptimization that UFS/FFS stores struct dirent directly on >> the disk. > >It would be nice if you guys could sit down and figure out just which >"proper fix" you want implemented, since everyone seems to have their own >ideas. I don't think I've seen any other proposals than to put it in dirent where it rightfully belongs. The reason it is not in dirent is that UFS/FFS uses dirent as the layout in directories as a microoptimization. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.