From owner-cvs-all@FreeBSD.ORG Mon Aug 7 11:46:09 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 08D0116A4DF; Mon, 7 Aug 2006 11:46:09 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id BAD1B43D72; Mon, 7 Aug 2006 11:45:58 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k77Bjula053823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 7 Aug 2006 15:45:57 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k77BjumJ053822; Mon, 7 Aug 2006 15:45:56 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 7 Aug 2006 15:45:56 +0400 From: Gleb Smirnoff To: Prafulla Deuskar Message-ID: <20060807114556.GC96644@FreeBSD.org> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> <20060804151422.GE96644@FreeBSD.org> <20060804162149.GB22299@hub.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060804162149.GB22299@hub.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Aug 2006 11:46:09 -0000 Prafulla, On Fri, Aug 04, 2006 at 04:21:49PM +0000, Prafulla Deuskar wrote: P> > Thanks. Any objections about merging the HEAD to RELENG_6 soon? P> P> Jack Vogel is doing the merge - I will send it out to you for review. P> So let us plan on committing early next week? The merge is very simple: 1) take the driver from HEAD 2) rename VLAN_INPUT_TAG() macro to VLAN_INPUT_TAG_NEW() 3) revert revision 1.105, since this functionality isn't yet in RELENG_6 I have prepared the patch last week and posted it on STABLE, and several people have already reported that they successfully run it. So, we can commit to RELENG_6, I think. P> Is there a report on what coverty found with if_em_hw.c? Coverity complains that the return value of em_read_phy_reg() is somtimes checked and sometimes is not. Can you please tell, whether this is important report or can it be ignored? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE