From owner-freebsd-current Sat Aug 26 15:22:30 2000 Delivered-To: freebsd-current@freebsd.org Received: from netplex.com.au (adsl-63-207-30-186.dsl.snfc21.pacbell.net [63.207.30.186]) by hub.freebsd.org (Postfix) with ESMTP id B8A0237B42C; Sat, 26 Aug 2000 15:22:21 -0700 (PDT) Received: from netplex.com.au (peter@localhost [127.0.0.1]) by netplex.com.au (8.11.0/8.9.3) with ESMTP id e7QMMEG25902; Sat, 26 Aug 2000 15:22:14 -0700 (PDT) (envelope-from peter@netplex.com.au) Message-Id: <200008262222.e7QMMEG25902@netplex.com.au> X-Mailer: exmh version 2.1.1 10/15/1999 To: Jonathan Chen Cc: Visigoth , current@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: DPT revision....(broken drivers in -STABLE) In-Reply-To: <20000826180321.A1703@spock.org> Date: Sat, 26 Aug 2000 15:22:14 -0700 From: Peter Wemm Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Jonathan Chen wrote: > On Wed, Aug 23, 2000 at 01:51:16PM -0500, Visigoth wrote: > > > Sorry for the cross post but.... > > > > Would it be possible to revert the DPT commits made by peter on > > Mon Aug 7 18:48:14 2000 in the RELENG_4 branch? It seems that the > > dpt_attatch is failing in bus_alloc_resource(9) for the IRQ, and I have > > production machines that need worlds built for some other updates as > > well.. I would be happy to install a -CURRENT machine and help debug > > until it works, but for right now, there is NO DPT support in -STABLE for > > the DPT PM3334UW. I had a pr started, but haven't been able to get any > > response from the current maintainer. > > > > I am going to install a -CURRENT machine with a DPT in it and > > start the process of working on the issue, but it would be nice if we can > > keep -STABLE stable... ;) > > I just updated on my -STABLE machine and ran into the same exact problem. > I also have on the machine SMP with APIC. The fix for this problem is > simple: Argh! I have committed this now, both in -current and RELENG_4. Thanks! > Index: dpt_pci.c > =================================================================== > RCS file: /export/ncvs/src/sys/dev/dpt/dpt_pci.c,v > retrieving revision 1.17.2.1 > diff -u -r1.17.2.1 dpt_pci.c > --- dpt_pci.c 2000/08/07 18:48:14 1.17.2.1 > +++ dpt_pci.c 2000/08/26 21:40:26 > @@ -106,7 +106,7 @@ > } > > rid = 0; > - irq = bus_alloc_resource(dev, SYS_RES_IRQ, &rid, 0, ~0, 1, RF_ACTIVE); > + irq = bus_alloc_resource(dev, SYS_RES_IRQ, &rid, 0, ~0, 1, RF_ACTIVE | RF_SHAREABLE); > if (!irq) { > device_printf(dev, "No irq?!\n"); > error = ENOMEM; > > (Everybody in unison, say "Doh!") > Since this didn't change in the past two months, I'm guessing this was > caused by somebody else futzing with APIC. In any case, I don't see why > the DPT card shouldn't be allowed to share IRQs, and I'm now running the > latest -STABLE on my DPT card. > > PS. Sorrry Matt for foiling your evil plot to get a free RAID card. ;) > > -- > (o_ 1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2-1-2 _o) > \\\_\ Jonathan Chen jon@spock.org /_/// > <____) No electrons were harmed during production of this message (____> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message