From owner-freebsd-current@FreeBSD.ORG  Thu Dec  1 11:39:01 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0EAA816A41F
	for <current@freebsd.org>; Thu,  1 Dec 2005 11:39:01 +0000 (GMT)
	(envelope-from hiten.pandya@gmail.com)
Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.205])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4B8D243D58
	for <current@freebsd.org>; Thu,  1 Dec 2005 11:39:00 +0000 (GMT)
	(envelope-from hiten.pandya@gmail.com)
Received: by zproxy.gmail.com with SMTP id r28so240191nza
	for <current@freebsd.org>; Thu, 01 Dec 2005 03:38:59 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=B0P9qk2OVCdhFzsoz+YynjJ2xLiS3mCozO35mwhtgirTLNna1JG9pU5w97TDUh80MrqK2p/6P01e75b0CGkm2vZMFDU5g8yG9c1VxrgUNuEWdQQ8e0WCts/AAzTCkrCpqZHyB8hrJrNbez+eVm+9Q0ylggJ92Xebs0Ua8eM9uWM=
Received: by 10.65.126.16 with SMTP id d16mr195013qbn;
	Thu, 01 Dec 2005 03:38:59 -0800 (PST)
Received: by 10.65.203.19 with HTTP; Thu, 1 Dec 2005 03:38:59 -0800 (PST)
Message-ID: <9b1858120512010338i2b190d83x@mail.gmail.com>
Date: Thu, 1 Dec 2005 11:38:59 +0000
From: Hiten Pandya <hiten.pandya@gmail.com>
To: Jason Evans <jasone@canonware.com>
In-Reply-To: <D53F6841-4A7D-4E61-A580-FE42EABE086A@canonware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <B6653214-2181-4342-854D-323979D23EE8@canonware.com>
	<9b1858120511290252w1e6d3458m@mail.gmail.com>
	<D53F6841-4A7D-4E61-A580-FE42EABE086A@canonware.com>
Cc: current@freebsd.org
Subject: Re: New libc malloc patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Dec 2005 11:39:01 -0000

Thanks Jason!

Kind Regards,

--
Hiten Pandya
hiten.pandya at gmail.com

On 01/12/05, Jason Evans <jasone@canonware.com> wrote:
> On Nov 29, 2005, at 2:52 AM, Hiten Pandya wrote:
> > I see that you have included an implementation of red-black tree CPP
> > macros, but wouldn't it be better if you were to use the ones in
> > <sys/tree.h> ?  I have only had a precursory look, but I would have
> > thought that would be the way to go.
>
> There's an updated patch available:
>
> http://www.canonware.com/~jasone/jemalloc/jemalloc_20051201a.diff
>
> This patch includes the following changes:
>
> *) Use sys/tree.h rather than a separate red-black tree implementation.
>
> *) Use the __isthreaded symbol to avoid locking for single-threaded
> programs, and to simplify malloc initialization.  The extra branches
> that are required to check __isthreaded should be more than offset by
> the removal of an atomic compare/swap operation.
>
> *) Fix an obscure bug (very difficult to trigger without changing
> some compile-time constants).
>
> Jason
>