From owner-freebsd-current@freebsd.org  Fri Sep 30 09:56:59 2016
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 50524C0148E;
 Fri, 30 Sep 2016 09:56:59 +0000 (UTC)
 (envelope-from martymac@FreeBSD.org)
Received: from lmtp.galacsys.net (webmail.galacsys.net
 [IPv6:2001:1b78:0:1:d918:51d7:0:1])
 by mx1.freebsd.org (Postfix) with ESMTP id 1184519A9;
 Fri, 30 Sep 2016 09:56:59 +0000 (UTC)
 (envelope-from martymac@FreeBSD.org)
Received: from martymac.org (webmail.galacsys.net [217.24.81.215])
 by lmtp.galacsys.net (Postfix) with ESMTP id 29F0F1FA5CFC;
 Fri, 30 Sep 2016 11:56:57 +0200 (CEST)
From: "Ganael LAPLANCHE" <martymac@FreeBSD.org>
To: Ultima <ultima1252@gmail.com>
Cc: freebsd-current@freebsd.org,freebsd-fs@freebsd.org
Subject: Re: [patch] Improving the 'zpool labelclear' command
X-Openwebmail-Date: Fri, 30 Sep 2016 11:56:57 +0100
Message-Id: <20160930095205.M29574@martymac.org>
In-Reply-To: <CANJ8om4A6f20F5Z9W-m0hCCQ5A207ftQOzdzXWF+uw9SJ+-3Dg@mail.gmail.com>
References: <CANJ8om4xX2pAkCxPTc8MarQo08cZ7R8j_M7aEKKV=2rtmm71yQ@mail.gmail.com>
 <op.yohxcavskndu52@d93fd8ae.cm-21.dynamic.ziggo.nl>
 <CANJ8om7aoG_Dy+7vCsBhuk9dcSsr60tfzrjhaspzPh9nj8vw-w@mail.gmail.com>
 <20160929121325.M80322@martymac.org>
 <CANJ8om4A6f20F5Z9W-m0hCCQ5A207ftQOzdzXWF+uw9SJ+-3Dg@mail.gmail.com>
X-Mailer: Open WebMail 2.01 20030425
X-OriginatingIP: 109.190.254.5 (ganael.laplanche@martymac.org)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
Date: Fri, 30 Sep 2016 09:56:59 -0000
X-List-Received-Date: Fri, 30 Sep 2016 09:56:59 -0000

On Thu, 29 Sep 2016 14:13:52 -0400, Ultima wrote

> > In case you are interested, I have posted a patch to improve the 'zpool
> > labelclear' command here :
> >
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204622
> >
> > - force ('-f') will now allow to erase labels, even if they are broken
> > (restoring the behaviour of our previous -FreeBSD- version of
labelclear)
> > - You can select which label you want to erase (beginning, end or
> > specific index)
> > - You can use a 'minimal' mode which will invalidate a label by changing
> > only a single byte. This is useful to minimize the chances to
> > overwrite/destroy a FS that would have been created over the label, but
> > still leaving the label visible.
>
> This patch looks good its too bad the core hasn't looked at it 
> yet. Ill do some testing and report any issues found. Some 
> points you bring up in the bug are quite valid. Thanks for 
> working on this! =]

Thanks. Yes, it would be nice if a src committer could take a look at it.

Any feedback welcome :)

--
Ganael LAPLANCHE <ganael.laplanche@martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org