From owner-freebsd-ports@FreeBSD.ORG  Sun May 24 16:01:06 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 65FA41065675;
	Sun, 24 May 2009 16:01:06 +0000 (UTC)
	(envelope-from itetcu@FreeBSD.org)
Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98])
	by mx1.freebsd.org (Postfix) with ESMTP id 1A3708FC1A;
	Sun, 24 May 2009 16:01:05 +0000 (UTC)
	(envelope-from itetcu@FreeBSD.org)
Received: from it.buh.tecnik93.com (localhost [127.0.0.1])
	by it.buh.tecnik93.com (Postfix) with ESMTP id 593C32C50CC3;
	Sun, 24 May 2009 19:01:33 +0300 (EEST)
Date: Sun, 24 May 2009 19:01:31 +0300
From: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
To: pav@FreeBSD.org
Message-ID: <20090524190131.0b30b101@it.buh.tecnik93.com>
In-Reply-To: <1243174223.18007.2.camel@hood.oook.cz>
References: <20090522.195350.193746535.chat95@mac.com>
	<20090522164138.236cb114@it.buh.tecnik93.com>
	<200905231101.59467.naylor.b.david@gmail.com>
	<20090523.182426.193741786.chat95@mac.com>
	<20090523135133.71a92669@it.buh.tecnik93.com>
	<1243174223.18007.2.camel@hood.oook.cz>
X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.1; i386-portbld-freebsd7.1)
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=PGP-SHA1;
	boundary="Sig_/7MgcjWm/U1LmeErt+ZssHzg";
	protocol="application/pgp-signature"
Cc: pgollucci@p6m7g8.com, naylor.b.david@gmail.com, freebsd-ports@FreeBSD.org
Subject: Re: MAKE_JOBS_UNSAFE (some more ports)
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 May 2009 16:01:06 -0000

--Sig_/7MgcjWm/U1LmeErt+ZssHzg
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, 24 May 2009 16:10:23 +0200
Pav Lucistnik <pav@FreeBSD.org> wrote:

> Ion-Mihai Tetcu p=C3=AD=C5=A1e v so 23. 05. 2009 v 13:51 +0300:
>=20
> > > > - MAKE_JOBS_NUMBER defaults (but user defined) to number of
> > > > cores
> >=20
> > This part looks OK, I wonder if there's any reason t ain't like this
> > now; Pav?
> > -.if defined(MAKE_JOBS_NUMBER)
> > +MAKE_JOBS_NUMBER?=3D	`${SYSCTL} -n kern.smp.cpus`
> >  _MAKE_JOBS=3D		-j${MAKE_JOBS_NUMBER}
> > -.else
> > -_MAKE_JOBS=3D		-j`${SYSCTL} -n kern.smp.cpus`
> > -.endif
>=20
> Wouldn't that mean an evaluation of the backtick command in every
> make(1) invocation? That would be highly undesirable.

Umm, why? it shouldn't be evaluated if MAKE_JOBS_NUMBER is defined, no?
Am I missing some make magic here?

--=20
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B

--Sig_/7MgcjWm/U1LmeErt+ZssHzg
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)

iEYEARECAAYFAkoZb1wACgkQJ7GIuiH/oeU9qQCgo83Jrz/L7sKdx0zCJ5JNFJyO
n58An2D7FYyz/ATv8ZnmOIQIrtqRaYXv
=ITEA
-----END PGP SIGNATURE-----

--Sig_/7MgcjWm/U1LmeErt+ZssHzg--